Reword and add tests

Author: xrmx

opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py

@@ -495,25 +495,9 @@ def _import_opamp() -> callable[[...], None]:
     # this in development, at the moment we are looking for a callable that takes
     # the resource and instantiate an OpAMP agent.
     # Since configuration is not specified every implementors may have its own.
-    # OpAMPAgent and OpAMPClient will be contributed once I finish writing tests :)
-    # def opamp_init(resource: Resource):
-    #     endpoint = os.environ.get("OTEL_PYTHON_OPAMP_ENDPOINT")
-    #     if endpoint:
-    #          opamp_client = OpAMPClient(
-    #                endpoint=endpoint,
-    #                agent_identifying_attributes={
-    #                    "service.name": resource.get("service.name"),
-    #                    "deployment.environment.name": resource.get("deployment.environment.name"),
-    #                },
-    #            )
-    #            opamp_agent = OpAMPAgent(
-    #                interval=30,
-    #                handler=opamp_handler, # this is an handler that gets called to process each OpAMP message
-    #                client=opamp_client,
-    #            )
-    #            opamp_agent.start()
+    # Refer to opentelemetry-opamp-client package on how to setup the OpAMP agent.
     _, opamp_init_func = _import_config_components(
-        ["_init_func"], "_opentelemetry_opamp"
+        ["init_function"], "_opentelemetry_opamp"
     )[0]
 
     return opamp_init_func
@@ -575,11 +559,7 @@ def _initialize_components(
     # This is different than other init helpers because setting up OpAMP requires distro
     # provided code as it's not strictly specified. We call OpAMP init before other code
     # because people may want to have it blocking to get an updated config before setting
-    # up the rest. Content of OpAMP config depends on the implementor and vendors will
-    # have their own. OpAMP to be fully integrated will need to introduce the concept of a
-    # config so we can track the difference between current config and a newly provided remote
-    # config. The goal is to have configuration updated dynamically while our SDK config is
-    # currently static.
+    # up the rest.
     try:
         _init_opamp = _import_opamp()
         _init_opamp(resource=resource)

opentelemetry-sdk/tests/test_configurator.py

@@ -1438,3 +1438,33 @@ def f(x):
         self.assertEqual(logging.config.dictConfig.__name__, "dictConfig")
         self.assertEqual(logging.basicConfig.__name__, "basicConfig")
         self.assertEqual(logging.config.fileConfig.__name__, "fileConfig")
+
+
+class TestOpAMPInit(TestCase):
+    @patch("opentelemetry.sdk._configuration.entry_points")
+    @patch("opentelemetry.sdk._configuration.Resource")
+    def test_init_function_found(self, mock_resource, mock_entry_points):
+        init_function = mock.Mock()
+        mock_entry_points.configure_mock(
+            return_value=[IterEntryPoint("init_function", init_function)]
+        )
+
+        _initialize_components(id_generator=1)
+
+        mock_entry_points.assert_has_calls(
+            [mock.call(group="_opentelemetry_opamp", name="init_function")]
+        )
+        init_function.assert_called_once_with(
+            resource=mock_resource.create.return_value
+        )
+
+    @patch("opentelemetry.sdk._configuration.entry_points")
+    def test_init_function_not_found(self, mock_entry_points):
+        mock_entry_points.configure_mock(return_value=[])
+
+        with self.assertLogs(level="DEBUG") as cm:
+            _initialize_components(id_generator=1)
+        self.assertIn(
+            "DEBUG:opentelemetry.sdk._configuration:No OpAMP init function found",
+            cm.output,
+        )