Rework error handling after comments

Author: xrmx

opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py

@@ -528,11 +528,25 @@ def _import_opamp() -> Callable[[...], None]:
     # the resource and instantiate an OpAMP agent.
     # Since configuration is not specified every implementors may have its own.
     # Refer to opentelemetry-opamp-client package on how to setup the OpAMP agent.
-    _, opamp_init_func = _import_config_components(
-        ["init_function"], "_opentelemetry_opamp"
-    )[0]
+    try:
+        entry_point = next(
+            iter(
+                entry_points(
+                    group="_opentelemetry_opamp", name="init_function"
+                )
+            )
+        )
+        return entry_point.load()
+    except StopIteration:
+        _logger.debug("No OpAMP init function found")
+    except AttributeError as exc:
+        _logger.warning(
+            "Failed to load OpAMP init function from entry point, %s: %s",
+            entry_point,
+            exc,
+        )
 
-    return opamp_init_func
+    return None
 
 
 def _initialize_components(
@@ -598,11 +612,9 @@ def _initialize_components(
     # provided code as it's not strictly specified. We call OpAMP init before other code
     # because people may want to have it blocking to get an updated config before setting
     # up the rest of the SDK.
-    try:
-        _init_opamp = _import_opamp()
+    _init_opamp = _import_opamp()
+    if _init_opamp is not None:
         _init_opamp(resource=resource)
-    except RuntimeError:
-        _logger.debug("No OpAMP init function found")
 
     _init_tracing(
         exporters=span_exporters,

opentelemetry-sdk/tests/test_configurator.py

@@ -1528,6 +1528,30 @@ def test_init_function_found(self, mock_resource, mock_entry_points):
             resource=mock_resource.create.return_value
         )
 
+    @patch("opentelemetry.sdk._configuration.entry_points")
+    def test_init_function_load_failure(self, mock_entry_points):
+        entry_point_mock = mock.Mock()
+        entry_point_mock.load.side_effect = AttributeError(
+            "module 'foo' has no attribute 'OpampInit'"
+        )
+        mock_entry_points.configure_mock(
+            return_value=[entry_point_mock],
+        )
+        entry_point_mock.__str__ = lambda x: "<EntryPoint>"
+
+        with self.assertLogs(level="WARNING") as cm:
+            _initialize_components(id_generator=1)
+
+        mock_entry_points.assert_has_calls(
+            [mock.call(group="_opentelemetry_opamp", name="init_function")]
+        )
+
+        self.assertIn(
+            "WARNING:opentelemetry.sdk._configuration:Failed to load OpAMP init function from entry point,"
+            " <EntryPoint>: module 'foo' has no attribute 'OpampInit'",
+            cm.output,
+        )
+
     @patch("opentelemetry.sdk._configuration.entry_points")
     def test_init_function_not_found(self, mock_entry_points):
         mock_entry_points.configure_mock(return_value=[])