Skip to content

Commit 9620bb6

Browse files
committed
fix test class split: move push exporter tests to separate class
The merge brought in push exporter plugin tests from #5128 which ended up in TestCreatePullMetricReaders. Moved them to a new TestCreateMetricReadersGeneral class with the _make_periodic_config helper they need. Assisted-by: Claude Opus 4.6
1 parent f20442e commit 9620bb6

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

opentelemetry-sdk/tests/_configuration/test_meter_provider.py

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -511,6 +511,20 @@ def test_pull_cardinality_limits_warns(self):
511511
create_meter_provider(config)
512512
self.assertTrue(any("cardinality_limits" in msg for msg in cm.output))
513513

514+
515+
class TestCreateMetricReadersGeneral(unittest.TestCase):
516+
@staticmethod
517+
def _make_periodic_config(exporter_config):
518+
return MeterProviderConfig(
519+
readers=[
520+
MetricReaderConfig(
521+
periodic=PeriodicMetricReaderConfig(
522+
exporter=exporter_config
523+
)
524+
)
525+
]
526+
)
527+
514528
def test_no_reader_type_raises(self):
515529
config = MeterProviderConfig(readers=[MetricReaderConfig()])
516530
with self.assertRaises(ConfigurationError):

0 commit comments

Comments
 (0)