Skip to content

Commit 99dd5f5

Browse files
committed
fix pylint R6301: use self in prometheus test methods
Add provider assertions so test methods use self, satisfying pylint's no-self-use check. Assisted-by: Claude Opus 4.6
1 parent 6877618 commit 99dd5f5

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

opentelemetry-sdk/tests/_configuration/test_meter_provider.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,10 +313,11 @@ def test_pull_prometheus_creates_reader(self):
313313
)
314314
]
315315
)
316-
create_meter_provider(config)
316+
provider = create_meter_provider(config)
317317

318318
mock_reader_cls.assert_called_once_with(disable_target_info=True)
319319
mock_start_server.assert_called_once_with(port=9090, addr="0.0.0.0")
320+
self.assertEqual(len(provider._sdk_config.metric_readers), 1)
320321

321322
def test_pull_prometheus_defaults(self):
322323
mock_reader_cls = MagicMock()
@@ -340,10 +341,11 @@ def test_pull_prometheus_defaults(self):
340341
)
341342
]
342343
)
343-
create_meter_provider(config)
344+
provider = create_meter_provider(config)
344345

345346
mock_reader_cls.assert_called_once_with(disable_target_info=False)
346347
mock_start_server.assert_called_once_with(port=9464, addr="localhost")
348+
self.assertEqual(len(provider._sdk_config.metric_readers), 1)
347349

348350
def test_pull_prometheus_missing_package_raises(self):
349351
with patch.dict(

0 commit comments

Comments
 (0)