Skip to content

Commit a1743b6

Browse files
Apply suggestions from code review
Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
1 parent 0cd70c0 commit a1743b6

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/measurement_consumer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ def __init__(
8383

8484
def _at_fork_reinit(self):
8585
"""Reinitialize lock in child process after fork"""
86-
self._lock._at_fork_reinit()
86+
self._lock = Lock()
8787
# Lazy reinitialization of storages on first use post fork. This is
8888
# done to avoid the overhead of reinitializing the storages on
8989
# every fork.

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/metric_reader_storage.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def __init__(
7777

7878
def _at_fork_reinit(self) -> None:
7979
"""Reinitialize locks and clear state in the child process after fork."""
80-
self._lock._at_fork_reinit()
80+
self._lock = Lock()
8181
self._instrument_view_instrument_matches.clear()
8282

8383
def _get_or_init_view_instrument_match(

opentelemetry-sdk/tests/metrics/test_measurement_consumer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828

2929

3030
def _sdk_config(exemplar_filter=None, resource=None, metric_readers=None, views=None):
31-
"""Create SdkConfiguration for tests. exemplar_filter is set as attribute after init."""
31+
"""Create SdkConfiguration for tests."""
3232
config = SdkConfiguration(
3333
resource=resource or Mock(),
3434
metric_readers=metric_readers or [Mock()],

0 commit comments

Comments
 (0)