Skip to content

Commit b634af7

Browse files
committed
docs: address review feedback, use deprecated and update propagate comment
1 parent da7e289 commit b634af7

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

docs/examples/logs/README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ The source files of these examples are available :scm_web:`here <docs/examples/l
1212

1313
``LoggingHandler`` has moved from the SDK to the
1414
``opentelemetry-instrumentation-logging`` package in the contrib repo
15-
and is no longer available in ``opentelemetry-sdk``.
15+
and is deprecated in ``opentelemetry-sdk``.
1616

1717

1818
Installation

docs/examples/logs/example.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,9 @@
5151
logger1 = logging.getLogger("myapp.area1")
5252
logger2 = logging.getLogger("myapp.area2")
5353

54-
# Ensure log records propagate to root logger so the handler picks them up
55-
logger1.propagate = True
56-
logger2.propagate = True
54+
# Propagate is True by default, ensure it is not set to False so log
55+
# records reach the root logger handler. See
56+
# https://docs.python.org/3/library/logging.html#logging.Logger.propagate
5757

5858
logger1.debug("Quick zephyrs blow, vexing daft Jim.")
5959
logger1.info("How quickly daft jumping zebras vex.")

0 commit comments

Comments
 (0)