Skip to content

Commit e905594

Browse files
authored
opentelemetry-sdk: fix a bunch of wrong type imports (#5062)
While at it remove an excluded file from typechecking that has no errors.
1 parent 02c639b commit e905594

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/_view_instrument_match.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@
2121
from opentelemetry.metrics import Instrument
2222
from opentelemetry.sdk.metrics._internal.aggregation import (
2323
Aggregation,
24+
AggregationTemporality,
2425
DefaultAggregation,
2526
_Aggregation,
2627
_SumAggregation,
2728
)
28-
from opentelemetry.sdk.metrics._internal.export import AggregationTemporality
2929
from opentelemetry.sdk.metrics._internal.measurement import Measurement
3030
from opentelemetry.sdk.metrics._internal.point import DataPointT
3131
from opentelemetry.sdk.metrics._internal.view import View

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/instrument.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,11 @@
3939

4040
if TYPE_CHECKING:
4141
from opentelemetry.sdk.metrics._internal import (
42-
MeasurementConsumer,
4342
_ProxyMeterConfig,
4443
)
44+
from opentelemetry.sdk.metrics._internal.measurement_consumer import (
45+
MeasurementConsumer,
46+
)
4547
from opentelemetry.sdk.util.instrumentation import InstrumentationScope
4648

4749

opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/metric_reader_storage.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@
2828
)
2929
from opentelemetry.sdk.metrics._internal.aggregation import (
3030
Aggregation,
31+
AggregationTemporality,
3132
ExplicitBucketHistogramAggregation,
3233
_DropAggregation,
3334
_ExplicitBucketHistogramAggregation,
3435
_ExponentialBucketHistogramAggregation,
3536
_LastValueAggregation,
3637
_SumAggregation,
3738
)
38-
from opentelemetry.sdk.metrics._internal.export import AggregationTemporality
3939
from opentelemetry.sdk.metrics._internal.measurement import Measurement
4040
from opentelemetry.sdk.metrics._internal.point import (
4141
ExponentialHistogram,

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ exclude = [
138138
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/instrument.py",
139139
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/measurement_consumer.py",
140140
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/metric_reader_storage.py",
141-
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/point.py",
142141
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/view.py",
143142
"opentelemetry-sdk/benchmarks",
144143
"exporter/opentelemetry-exporter-otlp-proto-grpc/tests",

0 commit comments

Comments
 (0)