docs: add missing tests for getting started examples#4662
Conversation
Add test_metrics.py and test_otlpcollector.py to validate the metrics_example.py and otlpcollector_example.py scripts. - test_metrics.py: Validates all 7 metric types with specific expected values - test_otlpcollector.py: Tests OTLP collector example with graceful timeout handling Fixes open-telemetry#4001
|
I think the issue was about running examples code in CI and not about writing some new tests |
My bad! 😄 i'll update! |
@xrmx - I do see that the existing tests run as part of CI. Example run from another PR that's open: https://github.com/open-telemetry/opentelemetry-python/actions/runs/15904348585/job/44855076756?pr=4659 Is there more to be done to add these tests to the CI pipeline? I see that they are configured here 🤔 |
|
@xrmx just checking in again - can you help clarify the requirements? |
|
@sginji please fix the lint errors and setup pre-commit and we should be good to go. |
f5442cb to
f249def
Compare
3378d99 to
081bf0a
Compare
@xrmx I've fixed lint and setup pre-commit too. |
…4662) * docs: add missing tests for getting started examples Add test_metrics.py and test_otlpcollector.py to validate the metrics_example.py and otlpcollector_example.py scripts. - test_metrics.py: Validates all 7 metric types with specific expected values - test_otlpcollector.py: Tests OTLP collector example with graceful timeout handling Fixes open-telemetry#4001 * Fix lint errors * Apply pre-commit fixes --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
…4662) * docs: add missing tests for getting started examples Add test_metrics.py and test_otlpcollector.py to validate the metrics_example.py and otlpcollector_example.py scripts. - test_metrics.py: Validates all 7 metric types with specific expected values - test_otlpcollector.py: Tests OTLP collector example with graceful timeout handling Fixes open-telemetry#4001 * Fix lint errors * Apply pre-commit fixes --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Description
Add test_metrics.py and test_otlpcollector.py to validate the metrics_example.py and otlpcollector_example.py scripts.
Fixes #4001
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: