Skip to content

fix: make client.py runnable without CLI arguments#4694

Merged
xrmx merged 7 commits into
open-telemetry:mainfrom
ddyczek:simplify-client-py-6721
Aug 28, 2025
Merged

fix: make client.py runnable without CLI arguments#4694
xrmx merged 7 commits into
open-telemetry:mainfrom
ddyczek:simplify-client-py-6721

Conversation

@ddyczek

@ddyczek ddyczek commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

There was an issue in the auto-instrumentation Example shown here:
https://opentelemetry.io/docs/zero-code/python/example/#execute-the-automatically-instrumented-server

The documentation refers to a client.py script located in docs/examples/auto-instrumentation, but the script previously required passing "testing" as a command-line argument each time (python client.py testing).

I've updated the script so that testing is now used as the default argument when none is provided. Users can still override it by passing a custom argument, but it will fall back to testing if nothing passed.

Refs: open-telemetry/opentelemetry.io#6721

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 21, 2025

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

@ddyczek ddyczek changed the title fix: make client.py runnable without CLI arguments" fix: make client.py runnable without CLI arguments Jul 22, 2025
@ddyczek ddyczek marked this pull request as ready for review July 22, 2025 18:51
@ddyczek ddyczek requested a review from a team as a code owner July 22, 2025 18:51
Comment thread docs/examples/auto-instrumentation/client.py Outdated
@pmcollins pmcollins force-pushed the simplify-client-py-6721 branch from 1552466 to 7d00efd Compare July 22, 2025 19:47
@xrmx xrmx moved this to Ready for review in Python PR digest Jul 23, 2025
Comment thread docs/examples/auto-instrumentation/client.py
@pmcollins pmcollins added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 28, 2025
@xrmx xrmx enabled auto-merge (squash) August 18, 2025 13:09
@xrmx xrmx merged commit 31289bd into open-telemetry:main Aug 28, 2025
468 of 469 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for review to Done in Python PR digest Aug 28, 2025
JWinermaSplunk pushed a commit to JWinermaSplunk/opentelemetry-python that referenced this pull request Feb 17, 2026
* remove: unused import

* add CLI parameter support with backward compatibility in client.py

* add comment explaining parameter usage

---------

Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
JWinermaSplunk pushed a commit to JWinermaSplunk/opentelemetry-python that referenced this pull request Feb 17, 2026
* remove: unused import

* add CLI parameter support with backward compatibility in client.py

* add comment explaining parameter usage

---------

Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants