Skip to content

feat: add experimental logger configurator#4980

Merged
xrmx merged 9 commits intoopen-telemetry:mainfrom
herin049:feat/logger-configurator
Apr 9, 2026
Merged

feat: add experimental logger configurator#4980
xrmx merged 9 commits intoopen-telemetry:mainfrom
herin049:feat/logger-configurator

Conversation

@herin049
Copy link
Copy Markdown
Contributor

Description

Follow up to #4861 to implement part of the Logging SDK spec to support logger configuration https://opentelemetry.io/docs/specs/otel/logs/sdk/#loggerconfigurator

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

tox -e py314-test-opentelemetry-sdk

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment.
If you're still working on this, please add a comment or push new commits.

@github-actions github-actions Bot added the Stale label Mar 29, 2026
@herin049 herin049 force-pushed the feat/logger-configurator branch from e1fb0ba to e420606 Compare April 4, 2026 02:25
@herin049 herin049 marked this pull request as ready for review April 4, 2026 03:20
@herin049 herin049 requested a review from a team as a code owner April 4, 2026 03:20
@herin049 herin049 added Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary and removed Stale labels Apr 4, 2026
@herin049 herin049 moved this to Ready for review in Python PR digest Apr 4, 2026
Copy link
Copy Markdown
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the naming of a couple of attributes LGTM, thanks!

Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py Outdated
Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py Outdated
Copy link
Copy Markdown
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but have one suggestion for using WeakSet.

Comment thread opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py Outdated
@herin049 herin049 force-pushed the feat/logger-configurator branch from 1c36493 to 283a54f Compare April 9, 2026 01:30
@xrmx xrmx enabled auto-merge (squash) April 9, 2026 07:29
@xrmx xrmx merged commit 37dea4b into open-telemetry:main Apr 9, 2026
1013 of 1015 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for review to Done in Python PR digest Apr 9, 2026
chimchim89 pushed a commit to chimchim89/opentelemetry-python that referenced this pull request Apr 15, 2026
* feat: add experimental LoggerConfigurator

* update SDK configuration to utilize logger configurator

* generalize rule based configurator

* add safe logger configurator application

* add unit tests

* update CHANGELOG.md

* update type annotation for active loggers

* Address PR comments.

---------

Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants