Skip to content

opentelemetry-sdk: fix a bunch of trivial typing issues in metrics #5033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrmx merged 2 commits into from
Apr 3, 2026
Merged

opentelemetry-sdk: fix a bunch of trivial typing issues in metrics #5033

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
263ccef
opentelemetry-sdk: fix a bunch of trivial typing issues in metrics
xrmx Apr 2, 2026
ca27f22
Merge branch 'main' into fix-metricreader-typing-path
xrmx Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions opentelemetry-sdk/src/opentelemetry/sdk/metrics/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.


from opentelemetry.sdk.metrics import export, view
from opentelemetry.sdk.metrics._internal import Meter, MeterProvider
from opentelemetry.sdk.metrics._internal.exceptions import MetricsTimeoutError
from opentelemetry.sdk.metrics._internal.exemplar import (
Expand Down Expand Up @@ -54,4 +55,6 @@
"SimpleFixedSizeExemplarReservoir",
"UpDownCounter",
"TraceBasedExemplarFilter",
"export",
"view",
]
2 changes: 1 addition & 1 deletion opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ def get_meter(
version: Optional[str] = None,
schema_url: Optional[str] = None,
attributes: Optional[Attributes] = None,
) -> Meter:
) -> APIMeter:
if self._disabled:
return NoOpMeter(name, version=version, schema_url=schema_url)

Expand Down
6 changes: 3 additions & 3 deletions opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/measurement_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@ def consume_measurement(self, measurement: Measurement) -> None:
def register_asynchronous_instrument(
self,
instrument: (
"opentelemetry.sdk.metrics._internal.instrument_Asynchronous"
"opentelemetry.sdk.metrics._internal.instrument._Asynchronous"
),
):
pass

@abstractmethod
def collect(
self,
metric_reader: "opentelemetry.sdk.metrics.MetricReader",
metric_reader: "opentelemetry.sdk.metrics.export.MetricReader",
timeout_millis: float = 10_000,
) -> Optional[MetricsData]:
pass
Expand Down Expand Up @@ -102,7 +102,7 @@ def register_asynchronous_instrument(

def collect(
self,
metric_reader: "opentelemetry.sdk.metrics.MetricReader",
metric_reader: "opentelemetry.sdk.metrics.export.MetricReader",
timeout_millis: float = 10_000,
) -> Optional[MetricsData]:
with self._lock:
Expand Down
4 changes: 2 additions & 2 deletions opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/sdk_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@
class SdkConfiguration:
exemplar_filter: "opentelemetry.sdk.metrics.ExemplarFilter"
resource: "opentelemetry.sdk.resources.Resource"
metric_readers: Sequence["opentelemetry.sdk.metrics.MetricReader"]
views: Sequence["opentelemetry.sdk.metrics.View"]
metric_readers: Sequence["opentelemetry.sdk.metrics.export.MetricReader"]
views: Sequence["opentelemetry.sdk.metrics.view.View"]
12 changes: 11 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,17 @@ include = [
exclude = [
"opentelemetry-sdk/tests",
"opentelemetry-sdk/src/opentelemetry/sdk/_events",
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/",
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/__init__.py",
Comment thread
DylanRussell marked this conversation as resolved.
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/_view_instrument_match.py",
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py",
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exemplar/exemplar_reservoir.py",
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/exponential_histogram/",
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/",
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/instrument.py",
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/measurement_consumer.py",
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/metric_reader_storage.py",
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/point.py",
"opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/view.py",
"opentelemetry-sdk/benchmarks",
"exporter/opentelemetry-exporter-otlp-proto-grpc/tests",
]
Expand Down
Loading