Skip to content

fix: separate pylint config for opentracing example to resolve FIXME#5037

Open
chimchim89 wants to merge 8 commits intoopen-telemetry:mainfrom
chimchim89:fix/separate-pylint-config
Open

fix: separate pylint config for opentracing example to resolve FIXME#5037
chimchim89 wants to merge 8 commits intoopen-telemetry:mainfrom
chimchim89:fix/separate-pylint-config

Conversation

@chimchim89
Copy link
Copy Markdown
Contributor

@chimchim89 chimchim89 commented Apr 3, 2026

Description

Resolves the FIXME in docs/examples/opentracing/rediscache.py.

The FIXME noted that # pylint: disable=import-error was needed because the example code was being linted under the main project's tox environment which did not have redis and redis_opentracing installed.

Changes made:

  • Removed FIXME comment and # pylint: disable=import-error from rediscache.py
  • Added lint-opentelemetry-opentracing-example to envlist in tox.ini
  • Added dedicated [testenv:lint-opentelemetry-opentracing-example] section with:
    • Dependencies from docs/examples/opentracing/requirements.txt
    • PYTHONPATH set to example folder so local module rediscache resolves correctly
    • Clean pylint command using root .pylintrc

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran the new lint environment:

tox -e lint-opentelemetry-opentracing-example

Result: Your code has been rated at 10.00/10

Ran ruff:

tox -e ruff

Result: all checks passed.

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@chimchim89 chimchim89 requested a review from a team as a code owner April 3, 2026 10:22
@xrmx
Copy link
Copy Markdown
Contributor

xrmx commented Apr 3, 2026

@chimchim89 I think you haven't pushed part of what the description says

@xrmx xrmx moved this to Reviewed PRs that need fixes in Python PR digest Apr 3, 2026
@chimchim89
Copy link
Copy Markdown
Contributor Author

chimchim89 commented Apr 3, 2026

@chimchim89 I think you haven't pushed part of what the description says

sorry for the confusion. that was a mistake on my side.

i have pushed the fix.

@chimchim89 chimchim89 force-pushed the fix/separate-pylint-config branch from 8d2c385 to f86bdf0 Compare April 4, 2026 04:55
@tammy-baylis-swi
Copy link
Copy Markdown
Contributor

Thanks! Please also add Changelog entry.

@chimchim89
Copy link
Copy Markdown
Contributor Author

Thanks! Please also add Changelog entry.

yes, added changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Reviewed PRs that need fixes

Development

Successfully merging this pull request may close these issues.

4 participants