proto: relax protobuf upper bound to <8.0#5100
Closed
tanmaydarmorha wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
proto: relax protobuf upper bound to <8.0#5100tanmaydarmorha wants to merge 1 commit intoopen-telemetry:mainfrom
tanmaydarmorha wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
|
|
Unblocks adoption of protobuf 7.x, which contains the fix for CVE-2026-8994 (DoS in google.protobuf.json_format.ParseDict). Mirrors the prior bump in open-telemetry#4620 (<6.0 -> <7.0). Refs open-telemetry#5099
814df4f to
ebabdcc
Compare
xrmx
reviewed
Apr 15, 2026
Contributor
xrmx
left a comment
There was a problem hiding this comment.
The CVE id is wrong, the severity for 2026-0994 as well and the fix has been backported to protobuf 5.29.6 and 6.33.4 as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relax the
protobufupper bound inopentelemetry-protofrom<7.0to<8.0so downstream users ofopentelemetry-exporter-otlp(and its proto-grpc / proto-common / proto-http variants) can adoptprotobuf>=7.0.Protobuf 7.0 contains the fix for CVE-2026-8994 (CVSS 7.58) — a DoS in
google.protobuf.json_format.ParseDict()where a malicious payload can bypass input validation. The current<7.0cap blocks users from picking up that fix without pinning around OTel constraints.This mirrors the prior bump pattern in #4620 (
<6.0→<7.0).googleapis-common-protosalready allowsprotobuf <8.0.0, so it is not a blocker.Fixes #5099
Type of change
How Has This Been Tested?
protobuf==7.34.1and confirmedopentelemetry.proto.*_pb2modules import and serialize/deserialize cleanly (wire format is stable across 5.x → 7.x).protobuf==5.29.5(existingtest-requirements.oldest.txt) to confirm the lower bound still resolves.CI coverage (tox) exercises the proto package against the existing pinned protobuf in
test-requirements.txt; no generated code changes, so existing unit tests are unaffected.Does This PR Require a Contrib Repo Change?
This PR only relaxes a dependency specifier in
opentelemetry-proto/pyproject.toml. No shared config files, CODEOWNERS, scripts copied to contrib, or public interfaces change.Checklist: