feat: make resource detector ordering deterministic#5120
Open
herin049 wants to merge 3 commits intoopen-telemetry:mainfrom
Open
feat: make resource detector ordering deterministic#5120herin049 wants to merge 3 commits intoopen-telemetry:mainfrom
herin049 wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
xrmx
approved these changes
Apr 17, 2026
| } | ||
| ) | ||
| otel_experimental_resource_detectors: list[str] = [ | ||
| d.strip() |
Contributor
There was a problem hiding this comment.
Don't want to sound like pylint but can we call this detector instead of d?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes the ordering and merging of resource detector attributes deterministic, with the
otelresource detector being last unless explicitly listed inOTEL_EXPERIMENTAL_RESOURCE_DETECTORS.Fixes #5054
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: