chore: enable PIE (flake8-pie) ruff rule#5150
Conversation
261560f to
7b6dbb7
Compare
cac4933 to
8ea69ce
Compare
8ea69ce to
15a5193
Compare
|
Thanks for the PR! Just a heads-up: we no longer update Please add the appropriate changelog fragment for this change instead of editing |
15a5193 to
ddec690
Compare
emdneto
left a comment
There was a problem hiding this comment.
Please add the appropriate changelog fragment for this change instead of editing CHANGELOG.md manually. You can find the instructions and expected format in CONTRIBUTING.md.
ddec690 to
6a4a576
Compare
796b97d to
2f4da80
Compare
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
|
This is approved and green, just got caught by the stale bot. The changelog already moved to a .changelog/5150.changed fragment for Towncrier, so there's nothing left on my side. Mind merging before it auto-closes? Can rebase for a fresh CI run if that helps. |
Part of open-telemetry#4227 Adds `PIE` to the ruff lint select list. Fixes all 49 auto-fixable violations (PIE790 unnecessary pass, PIE804 unnecessary dict kwargs, PIE808 unnecessary range start argument). Suppresses PIE796 on GenAiTokenTypeValues.COMPLETION which is an intentional deprecated alias for OUTPUT sharing the same enum value.
Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@hotmail.com>
Signed-off-by: Ogulcan Aydogan <ogulcanaydogan@hotmail.com>
2f4da80 to
aaf5dcd
Compare
Part of #4227
Adds
PIEto the ruff lintselectlist and fixes all violations.What changed
pyproject.toml: added"PIE"to[tool.ruff.lint] selectpassstatements in exception handlersdict(key=value)with{"key": value}literalsstart=0argument fromrange()calls# noqa: PIE796onGenAiTokenTypeValues.COMPLETIONingen_ai_attributes.py— this is an intentional deprecated alias sharing the same enum value asOUTPUTTesting