Review feedback

Author: thompson-tomo

instrumentation/active_record/Appraisals

@@ -32,4 +32,8 @@ if RUBY_ENGINE == 'jruby'
       gem 'activerecord-jdbcsqlite3-adapter', "~> #{version}"
     end
   end
+
+  appraise 'activerecord-latest' do
+    gem 'activerecord-jdbcsqlite3-adapter',
+  end
 end

instrumentation/net_ldap/.github-ci.yml

@@ -0,0 +1,2 @@
+env:
+  unsupported_interpreters: jruby

instrumentation/net_ldap/lib/opentelemetry/instrumentation/net/ldap/instrumentation_service.rb

@@ -32,8 +32,7 @@ def instrument(event, payload)
               'ldap.auth.username' => auth[:username].to_s,
               'ldap.operation.type' => operation_type,
               'ldap.request.message' => begin
-                raw = payload.to_json
-                utf8_clean?(raw) ? raw : nil
+                payload.to_json
               rescue JSON::GeneratorError
                 nil
               end,
@@ -100,19 +99,6 @@ def annotate_span_with_response(span, response)
 
             span.status = OpenTelemetry::Trace::Status.error
           end
-
-          def utf8_clean?(value)
-            case value
-            when String
-              value.scrub == value
-            when Hash
-              value.all? { |k, v| utf8_clean?(k) && utf8_clean?(v) }
-            when Array
-              value.all? { |v| utf8_clean?(v) }
-            else
-              true
-            end
-          end
         end
       end
     end