docs: improve gruf instrumentation documentation#2207
Conversation
arielvalentin
left a comment
There was a problem hiding this comment.
Thanks for your contribution. This is a great start.
I'd recommend also explicitly documenting any instrumentation specific configuration options as well as any extensions to semantic conventions that are unique to this instrumentation.
Would you be able to review the source for config options and semantic attributes and document them?
kaylareopelle
left a comment
There was a problem hiding this comment.
Something else that's often helpful in READMEs is to document the available configuration options for a repository.
Here are gruf's configs:
We don't have a consistent approach for documenting configs. Here are a few examples:
3ff9a55 to
8663efb
Compare
|
Hi @allexistence. Thanks for your patience. I think your changes look good. There are failing checks now related to formatting. Can you take a look? |
thompson-tomo
left a comment
There was a problem hiding this comment.
@allexistence can you add documentation to the top of the example controller as mentioned in https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/28316231103/job/83890038917
bc624eb to
9c71efd
Compare
- Replace placeholder description with overview and how-it-works sections - Document config options and semantic conventions - Add module/class documentation, remove Style/Documentation suppression - Add top-level documentation to example controller Signed-off-by: rishank69@gmail.com <rishank69@gmail.com>
9c71efd to
98ef695
Compare
thompson-tomo
left a comment
There was a problem hiding this comment.
Looks good, failing tests are unrelated.
e6c4b75
Fixes #2201
What this PR does
Improves gruf instrumentation documentation by:
Notes
Doc only change