Skip to content

docs: improve gruf instrumentation documentation#2207

Merged
kaylareopelle merged 3 commits into
open-telemetry:mainfrom
allexistence:docs/add-gruf-readme
Jul 3, 2026
Merged

docs: improve gruf instrumentation documentation#2207
kaylareopelle merged 3 commits into
open-telemetry:mainfrom
allexistence:docs/add-gruf-readme

Conversation

@allexistence

Copy link
Copy Markdown
Contributor

Fixes #2201

What this PR does

Improves gruf instrumentation documentation by:

  • Replacing placeholder description
  • Adding overview and "how it works"
  • Documenting key source files

Notes

Doc only change

@arielvalentin arielvalentin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. This is a great start.

I'd recommend also explicitly documenting any instrumentation specific configuration options as well as any extensions to semantic conventions that are unique to this instrumentation.

Would you be able to review the source for config options and semantic attributes and document them?

Comment thread instrumentation/gruf/README.md Outdated

@kaylareopelle kaylareopelle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something else that's often helpful in READMEs is to document the available configuration options for a repository.

Here are gruf's configs:

option :peer_service, default: nil, validate: :string
option :grpc_ignore_methods_on_client, default: [], validate: :array
option :grpc_ignore_methods_on_server, default: [], validate: :array
option :allowed_metadata_headers, default: [], validate: :array

We don't have a consistent approach for documenting configs. Here are a few examples:

  • net_ldap
  • redis
  • grape
  • sidekiq - This one is very different, as it just uses RDoc/Yard to document rather than including the content in the README. However, the content is very thorough.

@allexistence allexistence force-pushed the docs/add-gruf-readme branch from 3ff9a55 to 8663efb Compare June 4, 2026 04:30
@allexistence allexistence requested review from a team and thompson-tomo as code owners June 4, 2026 04:30
@kaylareopelle

Copy link
Copy Markdown
Contributor

Hi @allexistence. Thanks for your patience. I think your changes look good. There are failing checks now related to formatting. Can you take a look?

@thompson-tomo thompson-tomo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allexistence can you add documentation to the top of the example controller as mentioned in https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/28316231103/job/83890038917

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 29, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@allexistence allexistence force-pushed the docs/add-gruf-readme branch from bc624eb to 9c71efd Compare June 29, 2026 08:14
- Replace placeholder description with overview and how-it-works sections
- Document config options and semantic conventions
- Add module/class documentation, remove Style/Documentation suppression
- Add top-level documentation to example controller

Signed-off-by: rishank69@gmail.com <rishank69@gmail.com>
@allexistence allexistence force-pushed the docs/add-gruf-readme branch from 9c71efd to 98ef695 Compare June 29, 2026 08:16

@thompson-tomo thompson-tomo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, failing tests are unrelated.

@kaylareopelle kaylareopelle added this pull request to the merge queue Jul 3, 2026
Merged via the queue into open-telemetry:main with commit e6c4b75 Jul 3, 2026
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document gruf source files

4 participants