chore: Address inability to test on jruby#2421
Open
thompson-tomo wants to merge 5 commits into
Open
Conversation
thompson-tomo
requested review from
a team,
arielvalentin,
dazuma,
hannahramadan,
kaylareopelle,
robbkidd,
simi and
xuan-cao-swi
as code owners
github-actions
Bot
added
ci
instrumentation-rails
instrumentation-action_mailer
instrumentation-action_pack
instrumentation-action_view
instrumentation-active_record
instrumentation-active_storage
instrumentation-delayed_job
instrumentation-graphql
instrumentation-logger
instrumentation-net_ldap
labels
kaylareopelle
requested changes
Jul 3, 2026
kaylareopelle
left a comment
kaylareopelle
left a comment
Contributor
There was a problem hiding this comment.
Thanks for opening this, @thompson-tomo!
Contributor
Author
|
No worries @kaylareopelle, i have made the requested changes and raised seperate pr for net-ldap |
thompson-tomo
requested review from
kaylareopelle
and removed request for
arielvalentin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes some of the jruby exclusions by adjusting the appraisals to use different adapters etc.