Skip to content

Commit 04b6a6f

Browse files
authored
fix: prevent logging of header values in tonic debug logs (#3465)
1 parent 37c7a02 commit 04b6a6f

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

opentelemetry-otlp/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@
5151
- Fixed [#2777](https://github.com/open-telemetry/opentelemetry rust/issues/2777) to properly handle `shutdown_with_timeout()` when using `grpc-tonic`.
5252
- Deprecate `tls` feature in favor of explicit `tls-ring` and `tls-aws-lc` features.
5353
**Migration**: Replace `tls` with `tls-ring` (or `tls-aws-lc`). Users of `tls-roots` or `tls-webpki-roots` must now also enable one of these.
54+
- Prevent logging of header values in OTLP tonic exporter [#3465](https://github.com/open-telemetry/opentelemetry-rust/pull/3465)
5455

5556
## 0.31.0
5657

opentelemetry-otlp/src/exporter/tonic/mod.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@ impl TonicExporterBuilder {
232232
let compression = self.resolve_compression(signal_compression_var)?;
233233

234234
let (headers_from_env, headers_for_logging) = parse_headers_from_env(signal_headers_var);
235+
235236
let metadata = merge_metadata_with_headers_from_env(
236237
self.tonic_config.metadata.unwrap_or_default(),
237238
headers_from_env,
@@ -586,7 +587,7 @@ fn merge_metadata_with_headers_from_env(
586587
}
587588
}
588589

589-
fn parse_headers_from_env(signal_headers_var: &str) -> (HeaderMap, Vec<(String, String)>) {
590+
fn parse_headers_from_env(signal_headers_var: &str) -> (HeaderMap, Vec<String>) {
590591
let mut headers = Vec::new();
591592

592593
(
@@ -595,7 +596,7 @@ fn parse_headers_from_env(signal_headers_var: &str) -> (HeaderMap, Vec<(String,
595596
.map(|input| {
596597
parse_header_string(&input)
597598
.filter_map(|(key, value)| {
598-
headers.push((key.to_owned(), value.clone()));
599+
headers.push(key.to_owned());
599600
Some((
600601
HeaderName::from_str(key).ok()?,
601602
HeaderValue::from_str(&value).ok()?,

0 commit comments

Comments
 (0)