Skip to content

Commit 755d247

Browse files
refactor(appender-tracing): rename method
1 parent 3fae417 commit 755d247

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

opentelemetry-appender-tracing/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
## vNext
44

55
- Add custom `InstrumentationScope` support via
6-
`OpenTelemetryTracingBridge::builder_with_scope(..)`.
6+
`OpenTelemetryTracingBridge::builder_with_scope_attributes(..)`.
77
[3415](https://github.com/open-telemetry/opentelemetry-rust/issues/3415)
88

99
## 0.32.0

opentelemetry-appender-tracing/src/layer.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ where
378378
/// Creates a bridge using the default OpenTelemetry logger scope.
379379
///
380380
/// The default scope uses an empty scope name for the appender logger.
381-
/// Use [`Self::builder_with_scope`] to provide a
381+
/// Use [`Self::builder_with_scope_attributes`] to provide a
382382
/// custom [`InstrumentationScope`].
383383
pub fn new(provider: &P) -> Self {
384384
Self::builder(provider).build()
@@ -401,7 +401,7 @@ where
401401

402402
/// Creates a builder that uses a custom OpenTelemetry [`InstrumentationScope`]
403403
/// for the appender logger.
404-
pub fn builder_with_scope(
404+
pub fn builder_with_scope_attributes(
405405
provider: &P,
406406
scope: InstrumentationScope,
407407
) -> OpenTelemetryTracingBridgeBuilder<P, L> {
@@ -952,8 +952,11 @@ mod tests {
952952
.with_attributes([KeyValue::new("scope-key", "scope-value")])
953953
.build();
954954
let subscriber = tracing_subscriber::registry().with(
955-
layer::OpenTelemetryTracingBridge::builder_with_scope(&logger_provider, scope.clone())
956-
.build(),
955+
layer::OpenTelemetryTracingBridge::builder_with_scope_attributes(
956+
&logger_provider,
957+
scope.clone(),
958+
)
959+
.build(),
957960
);
958961

959962
let _guard = tracing::subscriber::set_default(subscriber);

0 commit comments

Comments
 (0)