refactor(appender-tracing): cleanup OpenTelemetryTracingBridge API

Author: DmitryAstafyev

opentelemetry-appender-tracing/CHANGELOG.md

@@ -3,7 +3,6 @@
 ## vNext
 
 - Add custom `InstrumentationScope` support via
-  `OpenTelemetryTracingBridge::with_scope()` and
   `OpenTelemetryTracingBridge::builder_with_scope()`.
   [3415](https://github.com/open-telemetry/opentelemetry-rust/issues/3415)
 

opentelemetry-appender-tracing/src/layer.rs

@@ -325,17 +325,12 @@ where
     /// Creates a bridge using the default OpenTelemetry logger scope.
     ///
     /// The default scope uses an empty scope name for the appender logger.
-    /// Use [`Self::with_scope`] or [`Self::builder_with_scope`] to provide a
+    /// Use [`Self::builder_with_scope`] to provide a
     /// custom [`InstrumentationScope`].
     pub fn new(provider: &P) -> Self {
         Self::builder(provider).build()
     }
 
-    /// Creates the bridge with a custom OpenTelemetry [`InstrumentationScope`].
-    pub fn with_scope(provider: &P, scope: InstrumentationScope) -> Self {
-        Self::builder_with_scope(provider, scope).build()
-    }
-
     /// Creates a builder using the default OpenTelemetry logger scope.
     pub fn builder(provider: &P) -> OpenTelemetryTracingBridgeBuilder<P, L> {
         OpenTelemetryTracingBridgeBuilder {
@@ -868,48 +863,35 @@ mod tests {
             .with_schema_url("https://opentelemetry.io/schemas/1.0.0")
             .with_attributes([KeyValue::new("scope-key", "scope-value")])
             .build();
-        let subscribers = [
-            tracing_subscriber::registry().with(
-                layer::OpenTelemetryTracingBridge::builder_with_scope(
-                    &logger_provider,
-                    scope.clone(),
-                )
+        let subscriber = tracing_subscriber::registry().with(
+            layer::OpenTelemetryTracingBridge::builder_with_scope(&logger_provider, scope.clone())
                 .build(),
-            ),
-            tracing_subscriber::registry().with(layer::OpenTelemetryTracingBridge::with_scope(
-                &logger_provider,
-                scope,
-            )),
-        ];
-
-        for subscriber in subscribers {
-            let _guard = tracing::subscriber::set_default(subscriber);
-
-            error!(name: "scoped-event", target: "my-system", event_id = 20);
-            assert!(logger_provider.force_flush().is_ok());
-
-            let exported_logs = exporter
-                .get_emitted_logs()
-                .expect("Logs are expected to be exported.");
-            assert_eq!(exported_logs.len(), 1);
-            let log = exported_logs
-                .first()
-                .expect("At least one log is expected to be present.");
-
-            let instrumentation_scope = &log.instrumentation;
-            assert_eq!(instrumentation_scope.name(), "test.scope");
-            assert_eq!(instrumentation_scope.version(), Some("1.2.3"));
-            assert_eq!(
-                instrumentation_scope.schema_url(),
-                Some("https://opentelemetry.io/schemas/1.0.0")
-            );
-            assert!(instrumentation_scope.attributes().eq([KeyValue::new(
-                "scope-key",
-                "scope-value"
-            )]
-            .iter()));
-            exporter.reset();
-        }
+        );
+
+        let _guard = tracing::subscriber::set_default(subscriber);
+
+        error!(name: "scoped-event", target: "my-system", event_id = 20);
+        assert!(logger_provider.force_flush().is_ok());
+
+        let exported_logs = exporter
+            .get_emitted_logs()
+            .expect("Logs are expected to be exported.");
+        assert_eq!(exported_logs.len(), 1);
+        let log = exported_logs
+            .first()
+            .expect("At least one log is expected to be present.");
+
+        let instrumentation_scope = &log.instrumentation;
+        assert_eq!(instrumentation_scope.name(), "test.scope");
+        assert_eq!(instrumentation_scope.version(), Some("1.2.3"));
+        assert_eq!(
+            instrumentation_scope.schema_url(),
+            Some("https://opentelemetry.io/schemas/1.0.0")
+        );
+        assert!(instrumentation_scope
+            .attributes()
+            .eq([KeyValue::new("scope-key", "scope-value")].iter()));
+        exporter.reset();
     }
 
     #[test]