Skip to content

perf: Benchmarks for OTLP conversion #3307

Open
cijothomas wants to merge 22 commits into
open-telemetry:mainfrom
cijothomas:cijothomas/conversionperf
Open

perf: Benchmarks for OTLP conversion #3307
cijothomas wants to merge 22 commits into
open-telemetry:mainfrom
cijothomas:cijothomas/conversionperf

Conversation

@cijothomas
Copy link
Copy Markdown
Member

@cijothomas cijothomas commented Jan 9, 2026

Mostly to get a baseline of where is time being spent. That should help guide future perf optimizations.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.8%. Comparing base (dfdc478) to head (b63fd90).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3307   +/-   ##
=====================================
  Coverage   82.8%   82.8%           
=====================================
  Files        130     130           
  Lines      27289   27289           
=====================================
  Hits       22622   22622           
  Misses      4667    4667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas changed the title Benchmarks for OTLP conversion perf: Benchmarks for OTLP conversion Jan 10, 2026
@cijothomas cijothomas marked this pull request as ready for review January 30, 2026 16:31
@cijothomas cijothomas requested review from a team as code owners January 30, 2026 16:31
@scottgerring scottgerring reopened this Feb 24, 2026
@scottgerring
Copy link
Copy Markdown
Member

I note that the benchmark suite is failing I think because libopenssl is missing from the machines now. @trask I don't know if you happen to know if something happened to those runners (or if maybe we added new ones?)

https://github.com/open-telemetry/opentelemetry-rust/actions/runs/22340134406/job/64950532919?pr=3307

Comment thread opentelemetry-sdk/src/logs/export.rs
Comment thread opentelemetry-otlp/benches/logs_export.rs Outdated
Comment thread opentelemetry-proto/benches/logs.rs
Comment thread opentelemetry-otlp/Cargo.toml Outdated
@trask
Copy link
Copy Markdown
Member

trask commented Feb 26, 2026

I note that the benchmark suite is failing I think because libopenssl is missing from the machines now. @trask I don't know if you happen to know if something happened to those runners (or if maybe we added new ones?)

https://github.com/open-telemetry/opentelemetry-rust/actions/runs/22340134406/job/64950532919?pr=3307

hm, not sure, I don't think anyone has done anything recently (other than reboot it from time to time)

can you open a new community issue for tracking and link to the original one (to help me remember what I did before 😄)

@scottgerring
Copy link
Copy Markdown
Member

scottgerring commented Feb 27, 2026

I note that the benchmark suite is failing I think because libopenssl is missing from the machines now. @trask I don't know if you happen to know if something happened to those runners (or if maybe we added new ones?)
https://github.com/open-telemetry/opentelemetry-rust/actions/runs/22340134406/job/64950532919?pr=3307

hm, not sure, I don't think anyone has done anything recently (other than reboot it from time to time)

can you open a new community issue for tracking and link to the original one (to help me remember what I did before 😄)

Done - #3296 - thanks!
It could also be we didn't used to depend on this for our benchmark suite but i'm uncertain.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Thank you for your contribution! This PR has been automatically marked as stale because it has not had activity in the last 14 days. This may be due to a delay in review on our side or awaiting a response from you; either is fine, and we appreciate your patience.

It will be closed in 14 days if no further activity occurs. Pushing a new commit or leaving a comment will remove the stale label and keep the PR open.

@github-actions github-actions Bot added the Stale label May 8, 2026
@cijothomas cijothomas force-pushed the cijothomas/conversionperf branch from f8eae2c to 4a20793 Compare May 8, 2026 05:09
@cijothomas cijothomas force-pushed the cijothomas/conversionperf branch from 4a20793 to 5c46bd3 Compare May 8, 2026 05:11
@cijothomas cijothomas requested a review from scottgerring May 8, 2026 05:11
@github-actions github-actions Bot removed the Stale label May 9, 2026
@scottgerring
Copy link
Copy Markdown
Member

Hey @cijothomas had a quick look at this because of the benchmark failures - I think what is going on is that opentelemetry-prometheus is using its own benchmark harness, which is not criterion but rather the normal rust one. So it doesn't understand --save-baseline. I think we should line that crate up with the criterion usage otherwise to get it going again. I think this is also going to break on main for the period checking as it stands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants