feat(otlp): Improved support for OTLP JSON metrics serialization (NaN,Infinity,-Infinity)#3496
feat(otlp): Improved support for OTLP JSON metrics serialization (NaN,Infinity,-Infinity)#3496LorenzoTettamanti wants to merge 15 commits into
Conversation
…tion<f64> type. Added tests in json_serde.rs for HistogramDataPoint.sum,HistogramDataPoint.min,HistogramDataPoint.max
…etrics.v1.SummaryDataPoint.value,metrics.v1.Exemplar.value,metrics.v1.ExponentialHistogramDataPoint.zeroThreshold
…DataPoint.value,metrics.v1.Exemplar.value,metrics.v1.ExponentialHistogramDataPoint.zeroThreshold
…stogram NaN metrics test,Added gauge NaN metrics test
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3496 +/- ##
=====================================
Coverage 82.9% 82.9%
=====================================
Files 130 130
Lines 27350 27350
=====================================
Hits 22675 22675
Misses 4675 4675 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…sts for -Infinity,+Infinity and NaN for Vec<f64> type
|
Hi @LorenzoTettamanti — while reading the
The effect is that the crate can no longer deserialize its own serialized output whenever a histogram leaves Minimal repro (serialize a It serializes to Would it make sense to have the visitor accept null — e.g. add |
|
Hi @lazureykis , that's a great catch. I think that's a great idea to implement the |
Updates #3442
Changes
HistogramDataPointsum,min,maxOption<f64>HistogramDataPointexplicit_boundsVec<f64>ExponentialHistogramDataPointsum,min,maxOption<f64>ExponentialHistogramDataPointzero_thresholdf64SummaryDataPointsumf64NumberDataPoint::ValueAsDoublef64Exemplar::ValueAsDoublef64AnyValueDoubleValuef64Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes