Implement scope_info_enabled#3503
Open
ArthurSens wants to merge 1 commit into
Open
Conversation
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3503 +/- ##
=======================================
- Coverage 82.8% 82.8% -0.1%
=======================================
Files 130 130
Lines 27276 27284 +8
=======================================
- Hits 22609 22608 -1
- Misses 4667 4676 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cijothomas
reviewed
May 7, 2026
| without_counter_suffixes: bool, | ||
| namespace: Option<String>, | ||
| disable_scope_info: bool, | ||
| scope_info_enabled: bool, |
ArthurSens
commented
May 7, 2026
Comment on lines
95
to
98
| pub fn without_scope_info(mut self) -> Self { | ||
| self.disable_scope_info = true; | ||
| self.scope_info_enabled = false; | ||
| self | ||
| } |
Member
Author
There was a problem hiding this comment.
I kept the function just for backwards compatibility, but happy to remove it it isn't needed
ArthurSens
commented
May 7, 2026
| once_cell = { workspace = true } | ||
| opentelemetry = { workspace = true, features = ["metrics", "internal-logs"] } | ||
| opentelemetry_sdk = { workspace = true, features = ["metrics", "experimental_metrics_custom_reader"] } | ||
| opentelemetry_sdk = { workspace = true, features = ["metrics", "experimental_metrics_custom_reader", "spec_unstable_metrics_views"] } |
Member
Author
There was a problem hiding this comment.
I honestly don't understand why the LLM decided to add this here lol. I tried doing some research, but it seems way beyond my Rust knowledge
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3474, but entirely focused on the implementation of Instrumentation Scope.
Here I'm doing quite a few things:
otel_scope_infometric, which was removed from the spec long ago.without_scope_infotoscope_info_enabled, following the latest discussions we had at Prometheus exporter: Stabilize config optionscope_info_enabledopentelemetry-specification#5056Disclosure: Although I've done Rust before, I'm not great at it. I do rely on LLMs to write most of the code.
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes