chore: decouple opentelemetry-proto from opentelemetry-sdk#3512
Open
scottgerring wants to merge 7 commits into
Open
chore: decouple opentelemetry-proto from opentelemetry-sdk#3512scottgerring wants to merge 7 commits into
scottgerring wants to merge 7 commits into
Conversation
Member
Author
|
@lalitb I know you've worked on this before; it would be great to get your high-level opinions on this so I can push it in the right direction. I'm not sure if i've missed some important nuance given this has come up a few times but never landed! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3512 +/- ##
=======================================
+ Coverage 82.8% 83.0% +0.1%
=======================================
Files 130 129 -1
Lines 27289 27229 -60
=======================================
- Hits 22622 22614 -8
+ Misses 4667 4615 -52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
803374d to
4985d5c
Compare
4985d5c to
ec5443d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This refactors
opentelemetry-protoso it only contains generated OTLP protobuf types. The diff is substantial because of the orphan rules - opentelemetry-otlp cannot implement the conversion traits for foreign types into foreign types. My feeling is that we just need to pull off the bandaid here!The SDK/api-aware transform helpers have been moved into
opentelemetry-otlp, where they are used by the exporters. This removes the directopentelemetry/opentelemetry_sdkdependency fromopentelemetry-protoand makes the crate usable by consumers that only need OTLP wire-format types. This will also provide other options to structure changes like #3460 , where we could benefit from having the dependency the other way around (although this is by no means a done deal).Changes
opentelemetry_proto::transformmodule.opentelemetry-otlp::transformmodule.opentelemetry-protodocs and changelog to describe the crate as generated protobuf types only.Prior art / related work
This implements the SDK-decoupling part of:
prostfrom OTLP/JSON #3419 / feat: Decouple prost from otlp json #3451 - adjacent work to reduce unnecessary proto/exporter dependencies for OTLP JSON/prost usage