feat(sdk): add otel.sdk.processor.log.processed self-diagnostics metric#3514
Open
cijothomas wants to merge 1 commit into
Open
feat(sdk): add otel.sdk.processor.log.processed self-diagnostics metric#3514cijothomas wants to merge 1 commit into
cijothomas wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3514 +/- ##
=======================================
- Coverage 82.8% 82.8% -0.1%
=======================================
Files 130 130
Lines 27289 27364 +75
=======================================
+ Hits 22622 22680 +58
- Misses 4667 4684 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ed9e3f4 to
9ed6cfd
Compare
…ic to BatchLogProcessor
9ed6cfd to
36d0e77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
otel.sdk.processor.log.processedcounter toBatchLogProcessor, following the OTel SDK metrics semantic conventions.Gated behind the existing
experimental_metrics_bound_instrumentsfeature flag — bound instruments make this practical on the hot path (~1.8 ns per emit vs ~50 ns with unbound).Changes:
BatchLogProcessoremits a counter on everyemit()call with three attribute variants: success,queue_full, andprocessor_shutdowndocs/design/observability.mdtest.sh)Ordering requirement:
global::set_meter_provider()must be called before creating theLoggerProvider. Rust'sglobal::meter()returns a snapshot, not a delegate. See the design doc for details.