fix(prometheus): disable libtest bench harness to fix benchmark CI#3519
Merged
cijothomas merged 1 commit intoMay 18, 2026
Merged
Conversation
When opentelemetry-prometheus was restored to the workspace in open-telemetry#3500, the [lib] section with bench = false was not added. This causes criterion-compare-action to fail because cargo bench invokes the default libtest harness for the prometheus crate, which does not understand Criterion-specific flags like --save-baseline. Every other workspace member already has [lib] bench = false.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3519 +/- ##
=====================================
Coverage 82.8% 82.8%
=====================================
Files 130 130
Lines 27289 27289
=====================================
Hits 22622 22622
Misses 4667 4667 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cijothomas
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opentelemetry-prometheus was restored to the workspace in #3500, the [lib] section with bench = false was not added. This causes criterion-compare-action to fail because cargo bench invokes the default libtest harness for the prometheus crate, which does not understand Criterion-specific flags like --save-baseline.
It has caused CI failure in PR #3473 : https://github.com/open-telemetry/opentelemetry-rust/actions/runs/25944571790/job/76269789635?pr=3473
Every other workspace member already has [lib] bench = false.
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes