Skip to content

Commit 2649534

Browse files
committed
review feedback
1 parent 9efeb89 commit 2649534

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

specification/entities/entity-propagation.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ linkTitle: Entity Propagation
2121
* [Validation Requirements](#validation-requirements)
2222
* [Error Handling](#error-handling)
2323
* [Environment Variable Conflict Resolution](#environment-variable-conflict-resolution)
24-
- [EntityDetector](#entitydetector)
24+
- [EnvEntityDetector](#Enventitydetector)
2525

2626
<!-- tocstop -->
2727

@@ -53,8 +53,9 @@ To enable standardized entity propagation across OpenTelemetry implementations,
5353
this specification defines the `OTEL_ENTITIES` environment variable format and
5454
processing requirements.
5555

56-
The SDK SHOULD provide an `EntityDetector` which will use the `OTEL_ENTITIES` environment
57-
variable to discover and associate defined entities with the resource.
56+
The SDK that has access to environment variables MUST provide
57+
an `EnvEntityDetector` which will use the `OTEL_ENTITIES` environment variable
58+
to discover and associate defined entities with the resource.
5859

5960
The `OTEL_ENTITIES` environment variable contains a list of entities in a
6061
compact format designed for human readability and concise representation.
@@ -217,6 +218,6 @@ OTEL_ENTITIES="service{service.name=entity-service,service.instance.id=inst-1}[s
217218
# - Resource: remaining attributes from OTEL_RESOURCE_ATTRIBUTES that don't conflict: {custom.attr=resource-value}
218219
```
219220

220-
## EntityDetector
221+
## EnvEntityDetector
221222

222223
TODO: fill out

0 commit comments

Comments
 (0)