Support configuring SDK batch size in config using items or bytes#5070
Support configuring SDK batch size in config using items or bytes#5070iblancasa wants to merge 1 commit into
Conversation
…or bytes Signed-off-by: Israel Blancas <iblancasa@gmail.com>
|
I think first you need to define the SDK surface that actually allows it to be configured with a batch size in units other than spans/logs/data-points. https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#batching-processor has a https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/sdk.md#batching-processor has a https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#periodic-exporting-metricreader has (development) Then we can add a declarative configuration surface for it as well. I think it should be possible to add a unit without it being a breaking change, but we need to check and make sure implementations didn't do something like name it "maxLogRecordBatchSize", or something that would make it harder to use for bytes. I don't think library guidelines are the right place to put the specification for how SDKs handle batching. |
|
Please have a look at open-telemetry/opentelemetry-collector#15132: the same discussion is happening for collector exporterhelper. |
|
This PR was marked stale. It will be closed in 14 days without additional activity. |
|
please see https://gist.github.com/braydonk/78ec0cfe9079ab8b611f52c49830116c, recommend closing this PR. @braydonk |
|
For future readers: The project from the gist has been opened as a proper project proposal in the community repo. open-telemetry/community#3477 |
Fixes #5068
Changes
Add in-development guidance for configuring SDK batch size using
itemsorbytes, including declarative configuration support viabatch_size_unit.Similar to what we currently support in
exporter helperfrom OpenTelemetry Collector https://github.com/open-telemetry/opentelemetry-collector/tree/main/exporter/exporterhelperPrototype for go: open-telemetry/opentelemetry-go#8321
CHANGELOG.mdfile updated for non-trivial changes