feat: add service.instance.cost_center attribute (#3754)#3756
Open
urjitasharma-11 wants to merge 1 commit into
Open
feat: add service.instance.cost_center attribute (#3754)#3756urjitasharma-11 wants to merge 1 commit into
urjitasharma-11 wants to merge 1 commit into
Conversation
|
Comment on lines
+47
to
+55
| - id: entity.service.instance | ||
| type: entity | ||
| name: service.instance | ||
| attributes: | ||
| - ref: service.instance.id | ||
| requirement_level: required | ||
| - ref: service.instance.cost_center | ||
| requirement_level: recommended | ||
| role: descriptive No newline at end of file |
Contributor
There was a problem hiding this comment.
Add the new attribute to the existing entity.
| consumers MAY use this attribute to optimize telemetry collection | ||
| or improve user experience. | ||
| examples: ["critical", "high", "medium", "low"] | ||
| - id: service.instance.cost_center |
Contributor
There was a problem hiding this comment.
Suggested change
| - id: service.instance.cost_center | |
| - id: service.instance.cost_center.id |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3754
This PR introduces the
service.instance.cost_centerattribute to the semantic conventions registry.Context
Following discussions and alignment within the Service and Deployment SIG, we have moved the financial attribution metadata from the logical service level to the instance level. This decision was made because costs are primarily incurred by runtime entities, and
service.instancerepresents the actual compute unit where resource consumption happens.Changes
service.instance.cost_centerattribute definition.service.instanceentity.docs/registry/attributes/service.md,docs/registry/entities/service.md, anddocs/resource/service.mdto reflect the new attribute.This proposal supersedes #3397 and addresses the feedback regarding granular cost attribution in multi-region or multi-tenant deployments.