From 49cf407d336e900f6ee115806c01c71edba012bb Mon Sep 17 00:00:00 2001 From: cijothomas Date: Fri, 29 May 2026 13:27:22 -0700 Subject: [PATCH 1/3] [chore] Document the area ownership auto-close behavior in CONTRIBUTING.md and AREAS.md --- AREAS.md | 6 ++++++ CONTRIBUTING.md | 11 +++++++++++ 2 files changed, 17 insertions(+) diff --git a/AREAS.md b/AREAS.md index a8db4ead95..5b20525dab 100644 --- a/AREAS.md +++ b/AREAS.md @@ -19,6 +19,12 @@ for pull request (PR) reviews and issue triage. This document provides an overview of the semantic conventions areas, along with their owners, related project (and project board) as well as its current status. +> [!Note] +> PRs that modify files under `model/` touching an area marked `inactive` +> are automatically closed by a bot. See +> [Area ownership check](./CONTRIBUTING.md#area-ownership-check) in the +> contributing guide for the bypass procedure for legitimate bugfixes. + diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5bea0121e0..d107452bb2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -374,6 +374,17 @@ For more information on each check, see: - [Yamllint check](#yamllint-check) - Prettier formatting +### Area ownership check + +PRs that modify files under `model/` are validated against +[AREAS.md](./AREAS.md) by an automated check. PRs that touch areas with +no active SIG/project (status `inactive` in AREAS.md) are automatically +closed with an explanatory comment. + +If your PR is a bugfix to an inactive area whose `Notes` column explicitly +welcomes bugfixes, ask a maintainer/approver to apply the +`triage:accepted:ready` label and reopen the PR. + ### Auto formatting Semantic conventions have some autogenerated components and additionally can do From 24b88eca24dc5a95d1b9cd1fcc6aae721dc141c2 Mon Sep 17 00:00:00 2001 From: cijothomas Date: Fri, 29 May 2026 13:31:56 -0700 Subject: [PATCH 2/3] [chore] Document area ownership auto-close and improve bot message --- .../scripts/triage/check-changes-ownership.ts | 21 ++++++++++++++----- CONTRIBUTING.md | 1 + 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/.github/scripts/triage/check-changes-ownership.ts b/.github/scripts/triage/check-changes-ownership.ts index fae914db57..f0844bae7d 100644 --- a/.github/scripts/triage/check-changes-ownership.ts +++ b/.github/scripts/triage/check-changes-ownership.ts @@ -28,15 +28,26 @@ async function shouldSkipCheck() { } function getCommentText(changesWithoutOwners: string[]): string { - return ` -This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed: + return `👋 Thanks for your contribution! + +This PR modifies file(s) in area(s) that do not currently have an active SIG/project: - ${changesWithoutOwners.join('\n- ')} -Such changes may be rejected or put on hold until a new SIG/project is established. +Per the [area ownership process](https://github.com/open-telemetry/semantic-conventions/blob/main/AREAS.md), +changes to these areas need an active SIG/project, so this PR has been automatically +closed and labeled \`triage:rejected:declined\`. **This does not mean your change is +unwelcome** — here is what you can do next: + +- **Bugfix**: If the area's \`Notes\` column in \`AREAS.md\` explicitly welcomes bugfixes, + ask a maintainer/approver to apply the \`triage:accepted:ready\` label and reopen this + PR. See [Area ownership check](https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#area-ownership-check) + in the contributing guide. +- **New conventions or substantial changes**: Consider starting a new SIG/project. + See the [Project Management](https://github.com/open-telemetry/community/blob/main/project-management.md) guide. +- **Questions**: Open an issue or reach out in the \`#otel-semantic-conventions\` Slack channel. -Please refer to the [Semantic Convention Areas](https://github.com/open-telemetry/semantic-conventions/blob/main/AREAS.md) -document to see the current active SIGs and also to learn how to kick start a new one.`; +Thanks again for taking the time to contribute! 🙏`; } async function changesInInactiveAreas(): Promise { diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d107452bb2..68d914323d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -30,6 +30,7 @@ requirements and recommendations. - [Reviewer guidelines](#reviewer-guidelines) - [Automation](#automation) - [Consistency checks](#consistency-checks) + - [Area ownership check](#area-ownership-check) - [Auto formatting](#auto-formatting) - [Markdown style](#markdown-style) - [Misspell check](#misspell-check) From fdffed51bccea52ae81b0e864257bab5a66d3d3c Mon Sep 17 00:00:00 2001 From: cijothomas Date: Fri, 29 May 2026 14:17:42 -0700 Subject: [PATCH 3/3] Drop bypass-label recipe per review feedback --- .../scripts/triage/check-changes-ownership.ts | 16 +++++++--------- CONTRIBUTING.md | 5 ++--- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/.github/scripts/triage/check-changes-ownership.ts b/.github/scripts/triage/check-changes-ownership.ts index f0844bae7d..822d0b6159 100644 --- a/.github/scripts/triage/check-changes-ownership.ts +++ b/.github/scripts/triage/check-changes-ownership.ts @@ -36,16 +36,14 @@ This PR modifies file(s) in area(s) that do not currently have an active SIG/pro Per the [area ownership process](https://github.com/open-telemetry/semantic-conventions/blob/main/AREAS.md), changes to these areas need an active SIG/project, so this PR has been automatically -closed and labeled \`triage:rejected:declined\`. **This does not mean your change is -unwelcome** — here is what you can do next: - -- **Bugfix**: If the area's \`Notes\` column in \`AREAS.md\` explicitly welcomes bugfixes, - ask a maintainer/approver to apply the \`triage:accepted:ready\` label and reopen this - PR. See [Area ownership check](https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#area-ownership-check) - in the contributing guide. -- **New conventions or substantial changes**: Consider starting a new SIG/project. +closed and labeled \`triage:rejected:declined\`. + +This does not mean your change is unwelcome: + +- **For substantial changes or new conventions**: Consider starting a new SIG/project. See the [Project Management](https://github.com/open-telemetry/community/blob/main/project-management.md) guide. -- **Questions**: Open an issue or reach out in the \`#otel-semantic-conventions\` Slack channel. +- **If you believe this was closed in error**: Please reach out in the + \`#otel-semantic-conventions\` channel on the [CNCF Slack](https://slack.cncf.io/). Thanks again for taking the time to contribute! 🙏`; } diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 68d914323d..635f6e713e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -382,9 +382,8 @@ PRs that modify files under `model/` are validated against no active SIG/project (status `inactive` in AREAS.md) are automatically closed with an explanatory comment. -If your PR is a bugfix to an inactive area whose `Notes` column explicitly -welcomes bugfixes, ask a maintainer/approver to apply the -`triage:accepted:ready` label and reopen the PR. +If you believe a PR was closed in error, please reach out in the +`#otel-semantic-conventions` channel on the [CNCF Slack](https://slack.cncf.io/). ### Auto formatting