Skip to content

[chore] Document area ownership auto-close behavior #3760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cijothomas wants to merge 3 commits into
base: main
Choose a base branch
from
+31 −5
Open

[chore] Document area ownership auto-close behavior #3760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49cf407
[chore] Document the area ownership auto-close behavior in CONTRIBUTI…
cijothomas May 29, 2026
24b88ec
[chore] Document area ownership auto-close and improve bot message
cijothomas May 29, 2026
fdffed5
Drop bypass-label recipe per review feedback
cijothomas May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions .github/scripts/triage/check-changes-ownership.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,24 @@ async function shouldSkipCheck() {
}

function getCommentText(changesWithoutOwners: string[]): string {
return `
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
return `👋 Thanks for your contribution!

This PR modifies file(s) in area(s) that do not currently have an active SIG/project:

- ${changesWithoutOwners.join('\n- ')}

Such changes may be rejected or put on hold until a new SIG/project is established.
Per the [area ownership process](https://github.com/open-telemetry/semantic-conventions/blob/main/AREAS.md),
changes to these areas need an active SIG/project, so this PR has been automatically
closed and labeled \`triage:rejected:declined\`.

This does not mean your change is unwelcome:

- **For substantial changes or new conventions**: Consider starting a new SIG/project.
See the [Project Management](https://github.com/open-telemetry/community/blob/main/project-management.md) guide.
Comment on lines +43 to +44
Copy link
Copy Markdown
Contributor

@kamphaus kamphaus May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention federated SemConv as an option?

- **If you believe this was closed in error**: Please reach out in the
\`#otel-semantic-conventions\` channel on the [CNCF Slack](https://slack.cncf.io/).

Please refer to the [Semantic Convention Areas](https://github.com/open-telemetry/semantic-conventions/blob/main/AREAS.md)
document to see the current active SIGs and also to learn how to kick start a new one.`;
Thanks again for taking the time to contribute! 🙏`;
}

async function changesInInactiveAreas(): Promise<boolean> {
Expand Down
6 changes: 6 additions & 0 deletions AREAS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ for pull request (PR) reviews and issue triage.
This document provides an overview of the semantic conventions areas, along with
their owners, related project (and project board) as well as its current status.

> [!Note]
> PRs that modify files under `model/` touching an area marked `inactive`
> are automatically closed by a bot. See
> [Area ownership check](./CONTRIBUTING.md#area-ownership-check) in the
> contributing guide for the bypass procedure for legitimate bugfixes.

<!-- NOTE: THIS TABLE IS AUTOGENERATED. DO NOT EDIT BY HAND. -->
<!-- see internal/tools/scripts/update-sig-table.py -->
<!-- prettier-ignore-start -->
Expand Down
11 changes: 11 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ requirements and recommendations.
- [Reviewer guidelines](#reviewer-guidelines)
- [Automation](#automation)
- [Consistency checks](#consistency-checks)
- [Area ownership check](#area-ownership-check)
- [Auto formatting](#auto-formatting)
- [Markdown style](#markdown-style)
- [Misspell check](#misspell-check)
Expand Down Expand Up @@ -374,6 +375,16 @@ For more information on each check, see:
- [Yamllint check](#yamllint-check)
- Prettier formatting

### Area ownership check

PRs that modify files under `model/` are validated against
Copy link
Copy Markdown
Contributor

@kamphaus kamphaus May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the check-changes-ownership.ts also check SIG ownership for files under docs/ (eg. just changing the stability level of metrics)?

[AREAS.md](./AREAS.md) by an automated check. PRs that touch areas with
no active SIG/project (status `inactive` in AREAS.md) are automatically
closed with an explanatory comment.

If you believe a PR was closed in error, please reach out in the
`#otel-semantic-conventions` channel on the [CNCF Slack](https://slack.cncf.io/).

### Auto formatting

Semantic conventions have some autogenerated components and additionally can do
Expand Down
Loading