[chore] Switch to gh releases for weaver version#3829
Conversation
thompson-tomo
changed the title
kamphaus
moved this from Untriaged
to Needs More Approval
in Semantic Conventions Triage
There was a problem hiding this comment.
Pull request overview
This PR updates the Renovate configuration to track the OpenTelemetry Weaver version from GitHub Releases instead of Docker Hub, addressing Renovate’s inability to pin the Docker tag digest and keeping the referenced semconv schema URL in sync.
Changes:
- Switch the custom regex manager for Weaver from the
dockerdatasource togithub-releases. - Update the dependency identifier from
otel/weavertoopen-telemetry/weaver. - Add version extraction to normalize
vX.Y.Ztags to semver-compatible versions.
| depNameTemplate: "open-telemetry/weaver", | ||
| datasourceTemplate: "github-releases", | ||
| versioningTemplate: "semver", | ||
| extractVersionTemplate: "^v(?<version>.*)$" |
| depNameTemplate: "open-telemetry/weaver", | ||
| datasourceTemplate: "github-releases", | ||
| versioningTemplate: "semver", | ||
| extractVersionTemplate: "^v(?<version>.*)$" |
There was a problem hiding this comment.
Could we remove extractVersionTemplate here? The GitHub release tag and the value captured from the schema URL are both v-prefixed (for example, v0.24.2).
There was a problem hiding this comment.
The issue i suspect with doing that is you might either lose semver update types and everything would have no update type or worse it would fail due to unable to parse it using the semver versioningtemplate.
This way we know it works and is handled like other updates.
There was a problem hiding this comment.
Can you please test this? I believe currently extractVersionTemplate converts release v0.24.2 to 0.24.2, causing Renovate to generate a schema URL without v, which will 404
Changes
This switches to sourcing the weaver version from gh releases as opposed to docker hub. This switch is to address the error shown in the renovate dashboard #2101 due to not being able to pin it.
This is a transfer of what is working in the ruby contrib repo to keep semconv version up to date.
Important
Pull request acceptance is subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above may be automatically rejected and closed.
Merge requirement checklist
Footnotes
Yes, I can answer maintainer questions about the content of this PR without using AI. ↩