Re-enable burn tests on Kusama and Polkadot relays (#599)

* Re-enable burn tests on Kusama relay; keep them disabled on Polkadot

Kusama passes at the current known-good block because the AHM accounts
migration has not yet run there, so validator accounts still have free
balance on the relay chain and fee routing via DealWithFees/ToAuthor
succeeds. Polkadot's known-good block is past that migration, leaving
validator accounts with free = 0, which causes ToAuthor to silently
drop the fee credit and reduce TotalIssuance by 0.2 * fee, breaking
the strict equality assertion in the burn tests.

Polkadot tests will be re-enabled once DealWithFees/ToAuthor is fixed
upstream to not drop fee credits when the author account is below ED.
See paritytech/polkadot-sdk#9986.

* Update Bifrost Polkadot endpoint

* Re-enable Polkadot relay burn tests with proviso for 9986

The 20% of the extrinsic fee which would go to the block author would be
burned when the validator has had their relay balance zeroed because of
AHM migration.

This commit re-enables burn tests on relay chains, and accounts for the
case in which this happens, as the known-good block's author may have
had their relay balance zeroed post-AHM.

* Bump block numbers

Author: rockbmb

KNOWN_GOOD_BLOCK_NUMBERS_KUSAMA.env

@@ -1,11 +1,11 @@
-ASSETHUBKUSAMA_BLOCK_NUMBER=16117236
-BASILISK_BLOCK_NUMBER=13979556
-BIFROSTKUSAMA_BLOCK_NUMBER=13603047
-BRIDGEHUBKUSAMA_BLOCK_NUMBER=8093533
-CORETIMEKUSAMA_BLOCK_NUMBER=5028787
-ENCOINTERKUSAMA_BLOCK_NUMBER=13431695
-KARURA_BLOCK_NUMBER=11459919
-KUSAMA_BLOCK_NUMBER=33287711
-MOONRIVER_BLOCK_NUMBER=16069369
-PEOPLEKUSAMA_BLOCK_NUMBER=8837196
-SHIDEN_BLOCK_NUMBER=14593298
+ASSETHUBKUSAMA_BLOCK_NUMBER=16206825
+BASILISK_BLOCK_NUMBER=14005412
+BIFROSTKUSAMA_BLOCK_NUMBER=13636914
+BRIDGEHUBKUSAMA_BLOCK_NUMBER=8110565
+CORETIMEKUSAMA_BLOCK_NUMBER=5045562
+ENCOINTERKUSAMA_BLOCK_NUMBER=13460752
+KARURA_BLOCK_NUMBER=11476954
+KUSAMA_BLOCK_NUMBER=33321973
+MOONRIVER_BLOCK_NUMBER=16101333
+PEOPLEKUSAMA_BLOCK_NUMBER=8871143
+SHIDEN_BLOCK_NUMBER=14620911

KNOWN_GOOD_BLOCK_NUMBERS_POLKADOT.env

@@ -1,11 +1,11 @@
-ACALA_BLOCK_NUMBER=11002567
-ASSETHUBPOLKADOT_BLOCK_NUMBER=15071965
-ASTAR_BLOCK_NUMBER=13150626
-BIFROSTPOLKADOT_BLOCK_NUMBER=12035220
-BRIDGEHUBPOLKADOT_BLOCK_NUMBER=7540201
-COLLECTIVESPOLKADOT_BLOCK_NUMBER=8747176
-CORETIMEPOLKADOT_BLOCK_NUMBER=4131048
-HYDRATION_BLOCK_NUMBER=12235278
-MOONBEAM_BLOCK_NUMBER=15403969
-PEOPLEPOLKADOT_BLOCK_NUMBER=4456978
-POLKADOT_BLOCK_NUMBER=30994178
+ACALA_BLOCK_NUMBER=11019681
+ASSETHUBPOLKADOT_BLOCK_NUMBER=15167298
+ASTAR_BLOCK_NUMBER=13177290
+BIFROSTPOLKADOT_BLOCK_NUMBER=12064006
+BRIDGEHUBPOLKADOT_BLOCK_NUMBER=7557364
+COLLECTIVESPOLKADOT_BLOCK_NUMBER=8764227
+CORETIMEPOLKADOT_BLOCK_NUMBER=4148211
+HYDRATION_BLOCK_NUMBER=12259837
+MOONBEAM_BLOCK_NUMBER=15436402
+PEOPLEPOLKADOT_BLOCK_NUMBER=4474388
+POLKADOT_BLOCK_NUMBER=31028926

packages/kusama/src/kusama.accounts.e2e.test.ts

@@ -2,19 +2,14 @@ import { kusama } from '@e2e-test/networks/chains'
 import {
   accountsE2ETests,
   createAccountsConfig,
-  type DescribeNode,
   manualLockAction,
   manualReserveAction,
   multisigCreationDepositAction,
   proxyAdditionDepositAction,
-  type RootTestTree,
   registerTestTree,
   type TestConfig,
-  type TestNode,
 } from '@e2e-test/shared'
 
-import { match } from 'ts-pattern'
-
 const generalTestConfig: TestConfig = {
   testSuiteName: 'Kusama Accounts',
 }
@@ -37,30 +32,4 @@ const accountsTestCfg = createAccountsConfig({
   },
 })
 
-/**
- * `burn` tests are temporarily disabled on Kusama relay, see
- * https://github.com/paritytech/polkadot-sdk/issues/9986.
- *
- * TODO: reenable after fix
- */
-const filterOutBurnTests = (tree: RootTestTree): RootTestTree => {
-  const filterChildren = (children: (TestNode | DescribeNode)[]): (TestNode | DescribeNode)[] => {
-    return children
-      .filter((child) => !child.label.includes('burn'))
-      .map((child) => {
-        return match(child)
-          .with({ kind: 'test' }, () => child)
-          .with({ kind: 'describe' }, (desc) => {
-            return { ...desc, children: filterChildren(desc.children) }
-          })
-          .exhaustive()
-      })
-  }
-
-  return {
-    ...tree,
-    children: filterChildren(tree.children),
-  }
-}
-
-registerTestTree(filterOutBurnTests(accountsE2ETests(kusama, generalTestConfig, accountsTestCfg)))
+registerTestTree(accountsE2ETests(kusama, generalTestConfig, accountsTestCfg))

packages/networks/src/pet-chain-endpoints.json

@@ -57,8 +57,8 @@
     "wss://acala-rpc-3.aca-api.network/ws"
   ],
   "bifrostPolkadot": [
-    "wss://hk.p.bifrost-rpc.liebi.com/ws",
-    "wss://eu.bifrost-polkadot-rpc.liebi.com/ws"
+    "wss://eu.bifrost-polkadot-rpc.liebi.com/ws",
+    "wss://hk.p.bifrost-rpc.liebi.com/ws"
   ],
   "hydration": [
     "wss://hydration.dotters.network",

packages/polkadot/src/polkadot.accounts.e2e.test.ts

@@ -2,30 +2,25 @@ import { polkadot } from '@e2e-test/networks/chains'
 import {
   accountsE2ETests,
   createAccountsConfig,
-  type DescribeNode,
   manualLockAction,
   manualReserveAction,
   multisigCreationDepositAction,
   proxyAdditionDepositAction,
-  type RootTestTree,
   registerTestTree,
   type TestConfig,
-  type TestNode,
 } from '@e2e-test/shared'
 
-import { match } from 'ts-pattern'
-
 const generalTestConfig: TestConfig = {
   testSuiteName: 'Polkadot Accounts',
 }
 
 // Staking and nomination pools are disabled on Polkadot relay, so the only reserve action available is manual.
 const reserveActions = [manualReserveAction()]
 
-// Vesting is also disabled, so the only lock action available is the manual lock.
+// Vesting is disabled on Polkadot relay, so the only lock action available is the manual lock.
 const lockActions = [manualLockAction()]
 
-// Referenda submission is no longer available, either.
+// Referenda submission is no longer available on Polkadot relay.
 const depositActions = [proxyAdditionDepositAction(), multisigCreationDepositAction()]
 
 const accountsTestCfg = createAccountsConfig({
@@ -37,24 +32,4 @@ const accountsTestCfg = createAccountsConfig({
   },
 })
 
-const filterOutBurnTests = (tree: RootTestTree): RootTestTree => {
-  const filterChildren = (children: (TestNode | DescribeNode)[]): (TestNode | DescribeNode)[] => {
-    return children
-      .filter((child) => !child.label.includes('burn'))
-      .map((child) => {
-        return match(child)
-          .with({ kind: 'test' }, () => child)
-          .with({ kind: 'describe' }, (desc) => {
-            return { ...desc, children: filterChildren(desc.children) }
-          })
-          .exhaustive()
-      })
-  }
-
-  return {
-    ...tree,
-    children: filterChildren(tree.children),
-  }
-}
-
-registerTestTree(filterOutBurnTests(accountsE2ETests(polkadot, generalTestConfig, accountsTestCfg)))
+registerTestTree(accountsE2ETests(polkadot, generalTestConfig, accountsTestCfg))

packages/shared/src/accounts.ts

@@ -3748,7 +3748,15 @@ async function burnTestBaseCase<
 
   // Check total issuance decreased by burn amount (fees are not included)
   const totalIssuanceAfterBurn = await client.api.query.balances.totalIssuance()
-  expect(totalIssuanceAfterBurn.toBigInt()).toBe(initialTotalIssuance.toBigInt() - burnAmount)
+  const tiDelta = initialTotalIssuance.toBigInt() - totalIssuanceAfterBurn.toBigInt()
+  if (client.config.isRelayChain) {
+    // On relay chains the block author may be below ED; if so, the fee credit is dropped and
+    // TI shrinks by an extra authorShare on top of the burn (polkadot-sdk#9986).
+    const authorShare = burnFee - (burnFee * 4n) / 5n
+    expect(tiDelta === burnAmount || tiDelta === burnAmount + authorShare).toBe(true)
+  } else {
+    expect(tiDelta).toBe(burnAmount)
+  }
 
   // Check burn event
   const eventsAfterBurn = await client.api.query.system.events()
@@ -3845,8 +3853,17 @@ async function burnTestWithReaping<
   // 4. Verify that the total issuance is decreased by the amount burned
   const totalIssuanceAfterBurn = await client.api.query.balances.totalIssuance()
   const isBifrost = chain.name.includes('bifrost')
+  const reapingFee = cumulativeFees.get(encodeAddress(alice.address, client.config.properties.addressEncoding))!
   const expectedDecrease = isBifrost ? burnAmount : burnAmount + (existentialDeposit - 1n)
-  expect(totalIssuanceAfterBurn.toBigInt()).toBe(initialTotalIssuance.toBigInt() - expectedDecrease)
+  const tiAfter = totalIssuanceAfterBurn.toBigInt()
+  const tiExpect = initialTotalIssuance.toBigInt() - expectedDecrease
+  if (client.config.isRelayChain) {
+    // Block author may be below ED; fee credit may be dropped, shrinking TI further (polkadot-sdk#9986).
+    const reapingAuthorShare = reapingFee - (reapingFee * 4n) / 5n
+    expect(tiAfter === tiExpect || tiAfter === tiExpect - reapingAuthorShare).toBe(true)
+  } else {
+    expect(tiAfter).toBe(tiExpect)
+  }
 }
 
 /**
@@ -3928,10 +3945,21 @@ async function burnKeepAliveTest<
   expect(aliceFinalBalance).toBe(aliceInitialBalance - transactionFee)
   expect(await isAccountReaped(client, alice.address)).toBe(false)
 
-  // 6. Verify that total issuance is unchanged
+  // 6. Verify that total issuance is unchanged (see polkadot-sdk#9986 for relay-chain author-drop case)
 
   const finalTotalIssuance = await client.api.query.balances.totalIssuance()
-  expect(finalTotalIssuance.toBigInt()).toBe(initialTotalIssuance.toBigInt())
+  const keepAliveFee = cumulativeFees.get(encodeAddress(alice.address, client.config.properties.addressEncoding))!
+  const keepAliveTI = finalTotalIssuance.toBigInt()
+  if (client.config.isRelayChain) {
+    // Block author may be below ED; fee credit may be dropped, shrinking TI (polkadot-sdk#9986).
+    const keepAliveAuthorShare = keepAliveFee - (keepAliveFee * 4n) / 5n
+    expect(
+      keepAliveTI === initialTotalIssuance.toBigInt() ||
+        keepAliveTI === initialTotalIssuance.toBigInt() - keepAliveAuthorShare,
+    ).toBe(true)
+  } else {
+    expect(keepAliveTI).toBe(initialTotalIssuance.toBigInt())
+  }
 
   // Verify no explicit Burned event for Alice (on Bifrost, fee-related Burned events are expected)
   const explicitBurns = findExplicitBurnEventsForAccount(systemEvents, client, alice.address, chain)
@@ -4041,10 +4069,21 @@ async function burnWithDepositTest<
   const expectedFreeBalance = aliceFreeBefore - totalFees
   expect(aliceAccountAfterBurn.data.free.toBigInt()).toBe(expectedFreeBalance)
 
-  // 5. Verify that total issuance is unchanged
+  // 5. Verify that total issuance is unchanged (see polkadot-sdk#9986 for relay-chain author-drop case)
 
   const finalTotalIssuance = await client.api.query.balances.totalIssuance()
-  expect(finalTotalIssuance.toBigInt()).toBe(initialTotalIssuance.toBigInt())
+  const depositFee = cumulativeFees.get(encodeAddress(alice.address, client.config.properties.addressEncoding))!
+  const depositTI = finalTotalIssuance.toBigInt()
+  if (client.config.isRelayChain) {
+    // Block author may be below ED; fee credit may be dropped, shrinking TI (polkadot-sdk#9986).
+    const depositAuthorShare = depositFee - (depositFee * 4n) / 5n
+    expect(
+      depositTI === initialTotalIssuance.toBigInt() ||
+        depositTI === initialTotalIssuance.toBigInt() - depositAuthorShare,
+    ).toBe(true)
+  } else {
+    expect(depositTI).toBe(initialTotalIssuance.toBigInt())
+  }
 
   // Verify no explicit Burned event for Alice
   const systemEvents = await client.api.query.system.events()
@@ -4157,10 +4196,23 @@ async function burnDoubleAttemptTest<
   expect(aliceFinalBalance).toBe(aliceInitialBalance - transactionFees)
   expect(await isAccountReaped(client, alice.address)).toBe(false)
 
-  // 5. Verify total issuance is unchanged
+  // 5. Verify total issuance is unchanged (see polkadot-sdk#9986 for relay-chain author-drop case)
+  // Two transactions: each fee goes through ration(80,20) independently, so we check per-fee drops.
 
   const finalTotalIssuance = await client.api.query.balances.totalIssuance()
-  expect(finalTotalIssuance.toBigInt()).toBe(initialTotalIssuance.toBigInt())
+  const doubleFee = cumulativeFees.get(encodeAddress(alice.address, client.config.properties.addressEncoding))!
+  const singleFee = doubleFee / 2n
+  const singleAuthorShare = singleFee - (singleFee * 4n) / 5n
+  const doubleTI = finalTotalIssuance.toBigInt()
+  const ti0 = initialTotalIssuance.toBigInt()
+  if (client.config.isRelayChain) {
+    // Block author is either consistently above or below ED for both txs in the same context;
+    // either both fee credits are dropped or neither is (polkadot-sdk#9986).
+    const doubleAuthorShare = singleAuthorShare * 2n
+    expect(doubleTI === ti0 || doubleTI === ti0 - doubleAuthorShare).toBe(true)
+  } else {
+    expect(doubleTI).toBe(ti0)
+  }
 
   // Verify no explicit Burned event for Alice
   const explicitBurns = findExplicitBurnEventsForAccount(systemEvents, client, alice.address, chain)