Update Bifrost Polkadot's accounts test suite (#590)

* Bump block numbers

* Update Bifrost Polkadot's accounts test suite

* Bump blocks numbers again

Author: rockbmb

KNOWN_GOOD_BLOCK_NUMBERS_KUSAMA.env

@@ -1,11 +1,11 @@
-ASSETHUBKUSAMA_BLOCK_NUMBER=15305629
-BASILISK_BLOCK_NUMBER=13800921
-BIFROSTKUSAMA_BLOCK_NUMBER=13311253
-BRIDGEHUBKUSAMA_BLOCK_NUMBER=7947584
-CORETIMEKUSAMA_BLOCK_NUMBER=4882966
-ENCOINTERKUSAMA_BLOCK_NUMBER=13181273
-KARURA_BLOCK_NUMBER=11313701
-KUSAMA_BLOCK_NUMBER=32994193
-MOONRIVER_BLOCK_NUMBER=15795614
-PEOPLEKUSAMA_BLOCK_NUMBER=8545260
-SHIDEN_BLOCK_NUMBER=14353488
+ASSETHUBKUSAMA_BLOCK_NUMBER=15574522
+BASILISK_BLOCK_NUMBER=13861581
+BIFROSTKUSAMA_BLOCK_NUMBER=13405501
+BRIDGEHUBKUSAMA_BLOCK_NUMBER=7994810
+CORETIMEKUSAMA_BLOCK_NUMBER=4930183
+ENCOINTERKUSAMA_BLOCK_NUMBER=13264547
+KARURA_BLOCK_NUMBER=11360932
+KUSAMA_BLOCK_NUMBER=33088991
+MOONRIVER_BLOCK_NUMBER=15883530
+PEOPLEKUSAMA_BLOCK_NUMBER=8639534
+SHIDEN_BLOCK_NUMBER=14431788

KNOWN_GOOD_BLOCK_NUMBERS_POLKADOT.env

@@ -1,11 +1,11 @@
-ACALA_BLOCK_NUMBER=10854087
-ASSETHUBPOLKADOT_BLOCK_NUMBER=14279589
-ASTAR_BLOCK_NUMBER=12911507
-BIFROSTPOLKADOT_BLOCK_NUMBER=11771423
-BRIDGEHUBPOLKADOT_BLOCK_NUMBER=7393319
-COLLECTIVESPOLKADOT_BLOCK_NUMBER=8599225
-CORETIMEPOLKADOT_BLOCK_NUMBER=3985013
-HYDRATION_BLOCK_NUMBER=12008996
-MOONBEAM_BLOCK_NUMBER=15123101
-PEOPLEPOLKADOT_BLOCK_NUMBER=4320323
-POLKADOT_BLOCK_NUMBER=30696137
+ACALA_BLOCK_NUMBER=10902025
+ASSETHUBPOLKADOT_BLOCK_NUMBER=14533018
+ASTAR_BLOCK_NUMBER=12990763
+BIFROSTPOLKADOT_BLOCK_NUMBER=11857098
+BRIDGEHUBPOLKADOT_BLOCK_NUMBER=7440339
+COLLECTIVESPOLKADOT_BLOCK_NUMBER=8646902
+CORETIMEPOLKADOT_BLOCK_NUMBER=4031499
+HYDRATION_BLOCK_NUMBER=12083573
+MOONBEAM_BLOCK_NUMBER=15213256
+PEOPLEPOLKADOT_BLOCK_NUMBER=4364097
+POLKADOT_BLOCK_NUMBER=30792329

packages/polkadot/src/bifrostPolkadot.accounts.e2e.test.ts

@@ -37,7 +37,7 @@ const depositActions = [
 ]
 
 const accountsCfg = createAccountsConfig({
-  expectation: 'failure',
+  expectation: 'success',
   actions: {
     reserveActions: createDefaultReserveActions(),
     lockActions,

packages/shared/src/accounts.ts

@@ -89,11 +89,11 @@ function findExplicitBurnEventsForAccount(
   address: string,
   chain: Chain<any, any>,
 ): FrameSystemEventRecord[] {
-  const isBifrostKusama = chain.name === 'bifrostKusama'
+  const isBifrost = chain.name === 'bifrostKusama' || chain.name === 'bifrostPolkadot'
   const encoded = encodeAddress(address, client.config.properties.addressEncoding)
 
   const feeAmounts = new Set<bigint>()
-  if (isBifrostKusama) {
+  if (isBifrost) {
     const feeInfos = client.config.properties.feeExtractor(events as unknown as any[], client.api)
     for (const fi of feeInfos) {
       if (fi.who === encoded) feeAmounts.add(fi.actualFee)
@@ -845,8 +845,8 @@ async function transferAllowDeathNoKillTest<
   expect(transferEventData.to.toString()).toBe(encodeAddress(bob.address, client.config.properties.addressEncoding))
   expect(transferEventData.amount.toBigInt()).toBe(transferAmount)
 
-  // On Bifrost Kusama, fees emit Burned (not Withdraw) events. Skip Withdraw check there.
-  if (chain.name !== 'bifrostKusama') {
+  // On Bifrost networks, fees emit Burned (not Withdraw) events. Skip Withdraw check there.
+  if (chain.name !== 'bifrostKusama' && chain.name !== 'bifrostPolkadot') {
     const withdrawEvent = events.find((record) => {
       const { event } = record
       if (event.section === 'balances' && event.method === 'Withdraw') {
@@ -4439,10 +4439,10 @@ export const accountsE2ETests = <
           label: 'self-transfer of entire balance',
           testFn: () => transferAllowDeathSelfTest(chain),
         },
-        // TODO: Bifrost Kusama's FlexibleFee rejects txs that would leave balance below ED after fees.
+        // TODO: Bifrost's FlexibleFee rejects txs that would leave balance below ED after fees.
         // See https://github.com/bifrost-io/bifrost/blob/develop/pallets/flexible-fee/src/lib.rs
         // Introduced in v0.22.0 (#1863): `can_withdraw` only matches `WithdrawConsequence::Success`.
-        ...(chain.name === 'bifrostKusama'
+        ...(chain.name === 'bifrostKusama' || chain.name === 'bifrostPolkadot'
           ? []
           : [
               {
@@ -4535,8 +4535,8 @@ export const accountsE2ETests = <
           label: 'transfer all with keepAlive true leaves 1 ED',
           testFn: () => transferAllKeepAliveTrueTest(chain),
         },
-        // TODO: same Bifrost Kusama FlexibleFee issue as above — see v0.22.0 (#1863)
-        ...(chain.name === 'bifrostKusama'
+        // TODO: same Bifrost FlexibleFee issue as above — see v0.22.0 (#1863)
+        ...(chain.name === 'bifrostKusama' || chain.name === 'bifrostPolkadot'
           ? []
           : [
               {
@@ -4645,8 +4645,8 @@ export const accountsE2ETests = <
           label: 'burning entire balance, or more than it, fails',
           testFn: () => burnDoubleAttemptTest(chain),
         },
-        // TODO: same Bifrost Kusama FlexibleFee issue as above — see v0.22.0 (#1863)
-        ...(chain.name === 'bifrostKusama'
+        // TODO: same Bifrost FlexibleFee issue as above — see v0.22.0 (#1863)
+        ...(chain.name === 'bifrostKusama' || chain.name === 'bifrostPolkadot'
           ? []
           : [
               {