Refactor accounts snapshots#562
Merged
Merged
Conversation
- setStakingConfigs gained an 8th parameter (are_nominators_slashable) - removeProxies now emits ProxyRemoved events per removed proxy. Fix related tests to be SDK's stable2512 compliant. Co-authored-by: Paolo La Camera <paolo@parity.io>
New staking pallet version used by `stable2512` runtimes introduced a new argument to `set_staking_configs`. The `postAhmFiltering` test suite checks that pallets disabled in relay chains after the AHM are indeed disasbled. The staking pallet dependency on the relay chain was *not* updated like the Hubs' dependency was; therefore, that test suite's usage of `staking.setStakingConfigs` need not be updated.
It is not worth it to refactor the test to account for the single chain in which they are unstable; best to just remove them, as they are cabally analyzed later in each relevant test, anyway.
rockbmb
added
e2e tests
Contributor
|
No issues found. |
xlc
approved these changes
Mar 13, 2026
Collaborator
Author
|
Kusama snapshots are failing due to a runtime upgrade downstreaming a recent change in the pure proxy creation event. This PR will also update proxy E2E snapshots. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #558 ; Hydration has some unstable snapshots. It is worth it to remove them altogether, since they are manually analyzed.
EDIT:
This PR was also expanded to handle: