Re-enable burn tests on Kusama and Polkadot relays#599
Merged
Conversation
Contributor
|
No issues found. |
rockbmb
added
e2e tests
rockbmb
force-pushed
the
reenable-burn-tests
branch
3 times, most recently
from
1ac708e to
d402b3f
Compare
rockbmb
force-pushed
the
reenable-burn-tests
branch
from
d402b3f to
8c81a3d
Compare
Kusama passes at the current known-good block because the AHM accounts migration has not yet run there, so validator accounts still have free balance on the relay chain and fee routing via DealWithFees/ToAuthor succeeds. Polkadot's known-good block is past that migration, leaving validator accounts with free = 0, which causes ToAuthor to silently drop the fee credit and reduce TotalIssuance by 0.2 * fee, breaking the strict equality assertion in the burn tests. Polkadot tests will be re-enabled once DealWithFees/ToAuthor is fixed upstream to not drop fee credits when the author account is below ED. See paritytech/polkadot-sdk#9986.
rockbmb
force-pushed
the
reenable-burn-tests
branch
from
8c81a3d to
16d5238
Compare
The 20% of the extrinsic fee which would go to the block author would be burned when the validator has had their relay balance zeroed because of AHM migration. This commit re-enables burn tests on relay chains, and accounts for the case in which this happens, as the known-good block's author may have had their relay balance zeroed post-AHM.
Collaborator
Author
|
paritytech/polkadot-sdk#11948 will close paritytech/polkadot-sdk#9986; after that downstreams to production runtimes, the patches applied here can be undone. |
xlc
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables
burntests on the Kusama relay that were temporarily disabledThe tests were disabled while waiting for a fix in paritytech/polkadot-sdk#9986. That issue has been resolved on Kusama.