Skip to content

Merge new KAH E2E tests into master#435

Merged
rockbmb merged 40 commits into
masterfrom
ahm-tests-update
Oct 15, 2025
Merged

Merge new KAH E2E tests into master#435
rockbmb merged 40 commits into
masterfrom
ahm-tests-update

Conversation

@rockbmb
Copy link
Copy Markdown
Collaborator

@rockbmb rockbmb commented Oct 8, 2025

Closes #431 .

With the AHM, Kusama AH gets the E2E test suites for staking, nomination pools, referenda, etc, while on Kusama relay, those should be disabled, as such calls are now filtered.

@rockbmb rockbmb added this to the Kusama Migration milestone Oct 8, 2025
@rockbmb rockbmb self-assigned this Oct 8, 2025
@rockbmb rockbmb added e2e tests Related to end-to-end tests refactor Changes to already-existing code. labels Oct 8, 2025
@rockbmb rockbmb changed the title Ahm tests update Merge new KAH E2E tests into master Oct 8, 2025
},
},
},
assetHubPaseo: {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to remove this, leftover from local testing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a continuation of my PR or something unrelated?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated; this branch contains the changes required of KAH E2E test suites to run on the new post-AHM runtimes; in the past, I had used to test Paseo things, and forgot to remove some things related to it.

Collator: 6,
}

export const AssetHubPaseoProxyTypes: ProxyTypeMap = {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes introduce E2E tests for Kusama Asset Hub and adjust existing test configurations. One issue was found in the updated logic for handling overweight scheduler calls, where an assertion seems to be using an incorrect value.

Comment thread packages/shared/src/scheduler.ts
@rockbmb rockbmb marked this pull request as ready for review October 10, 2025 16:20
@rockbmb rockbmb requested a review from xlc October 14, 2025 21:19
@rockbmb
Copy link
Copy Markdown
Collaborator Author

rockbmb commented Oct 14, 2025

Almost done; I will be pushing a fix that prevents #442 from happening again.

@xlc ready for review.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes introduce new E2E tests for Kusama Asset Hub and update existing test configurations. The review identified two issues in packages/shared/src/accounts.ts: a potentially incorrect hardcoded value for a reservation and a leftover commented-out debugging call.

Comment thread packages/shared/src/accounts.ts
Comment thread packages/shared/src/accounts.ts Outdated

await updateCumulativeFees(client.api, cumulativeFees, testConfig.addressEncoding)

//await client.pause()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A commented-out call to client.pause() should be removed. This is likely a remnant of a debugging session and is not needed.

`proxy.ProxyExecuted` event is enough for analysis to make the test
robust.
@rockbmb rockbmb merged commit 53b4799 into master Oct 15, 2025
85 of 87 checks passed
@rockbmb rockbmb deleted the ahm-tests-update branch October 15, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e tests Related to end-to-end tests refactor Changes to already-existing code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Merge AHM changes to Kusama E2E tests

3 participants