Cover edge cases in Registrar Pallet E2E tests#633
Merged
rockbmb merged 25 commits intoJun 24, 2026
Conversation
Contributor
Author
|
Hi @rockbmb, this is ready for review. |
Contributor
|
No issues found. The changes are well-structured and the new tests cover a comprehensive set of edge cases for the registrar pallet as described. The code is clear and follows existing patterns in the project. |
Collaborator
|
@naijauser will take a look ASAP! |
dda504d to
240ec64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #629
This PR covers the following additional edge cases:
register
MIN_CODE_SIZEMAX_CODE_SIZEMAX_HEAD_DATA_SIZEderegister
NotRegisteredadd_lock / remove_lock
add_lock/remove_lockcycle from the perspective of the para managerswap
NotRegisteredschedule_code_upgrade
NotRegisteredset_current_head
NotRegistered