fix: allow OAuth popups to open inside Electron webview#218
Open
pascal-sidlee wants to merge 1 commit into
Open
fix: allow OAuth popups to open inside Electron webview#218pascal-sidlee wants to merge 1 commit into
pascal-sidlee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OAuth popups (Google Drive, Google Sign-In, etc.) are blocked when triggered
from a webview because
setWindowOpenHandlerreturns{ action: 'deny' }forall popups. The popup opens in the system browser instead, which breaks the
OAuth handshake, the opener page can't receive the postMessage callback from
an external browser window.
Fix: whitelist known OAuth provider hosts so their popups open as child windows
inside Electron, where the callback can complete normally. All other popups
continue to open in the system browser.
Related Issues
Closes #175
Contributor License Agreement
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.