Skip to content

fix: allow OAuth popups to open inside Electron webview #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pascal-sidlee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow OAuth popups to open inside Electron webview #218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1313,7 +1313,20 @@ if (!gotTheLock) {

if (contents.getType() === 'webview') {
// ── Popups (target="_blank" links) → open in default browser ──
// OAuth popup windows (Google, Microsoft, GitHub, etc.) must open
// inside Electron so the opener page can receive the postMessage
// callback. All other popups go to the system browser.
const OAUTH_HOSTS = [
'accounts.google.com',
'login.microsoftonline.com',
'github.com/login',
'github.com/oauth',
]
contents.setWindowOpenHandler(({ url }) => {
const isOAuth = OAUTH_HOSTS.some((h) => url.includes(h))
if (isOAuth) {
return { action: 'allow' }
}
openUrl(url)
return { action: 'deny' }
})
Expand Down