assign_view: drop_unassigned should not drop rows with NaNs in other columns#241
Closed
OfficialBishal wants to merge 1 commit into
Closed
assign_view: drop_unassigned should not drop rows with NaNs in other columns#241OfficialBishal wants to merge 1 commit into
OfficialBishal wants to merge 1 commit into
Conversation
…her columns assign_view(drop_unassigned=True) dropped every row containing a NaN in any column, so intervals that were assigned to a view region were lost if they had a NaN in an unrelated column (e.g. cooler bins with missing weights). Only drop intervals whose view assignment is NaN, and add a regression test. Closes open2c#160
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #160.
assign_view(..., drop_unassigned=True)dropped every row containing a NaN in any column:So an interval that was assigned to a view region got dropped if it had a NaN in an unrelated column (the reporter's example: cooler bins with missing weights).
drop_unassignedshould only drop intervals that fall outside the view — i.e. whose assignment column (df_view_col) is NaN.Example — with
drop_unassigned=True, only thechr2row (outside the view) should be dropped, but before this PR thechr1:10-20row is also lost:Added
test_assign_view_drop_unassigned_keeps_nan_in_other_columns;pytest tests/test_ops.pypasses.