Skip to content

Commit 7ba0369

Browse files
Correct Web/Wasm authenticator claim — currently stubbed
Both jsMain and wasmJsMain PlatformAuthenticator implementations return PlatformAuthenticatorStatus.NOT_AVAILABLE for status, RegistrationResult.PlatformAuthenticatorNotAvailable for register, and AuthenticationResult.UserNotRegistered for authenticate. There is no WebAuthn integration in the source. FEATURES.md and README.md both claimed WebAuthn support; corrected to describe the targets as placeholders. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent fc6a6ee commit 7ba0369

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

FEATURES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,4 +70,4 @@ Planned work, tracked in GitHub issues. Each item is independent of the shipped
7070

7171
## Companion library
7272

73-
`mifos-authenticator-biometrics` is the companion library providing platform authenticator integration: Android `BiometricPrompt`, iOS `LocalAuthentication`, Windows Hello via JNA, and WebAuthn for Web/Wasm. It is fully decoupled from the passcode library — neither imports the other. Apps that need both wire them together at the consumer level (see `cmp-sample-shared` for a working example). The biometrics library exposes its own `BiometricStorageAdapter` and registration lifecycle; refer to `mifos-authenticator-biometrics/README.md` for its feature surface.
73+
`mifos-authenticator-biometrics` is the companion library providing platform authenticator integration: Android `BiometricPrompt`, iOS `LocalAuthentication`, and Windows Hello via JNA on Windows desktop. Web, Wasm, and non-Windows desktop targets currently stub the authenticator (always returning `NOT_AVAILABLE`). It is fully decoupled from the passcode library — neither imports the other. Apps that need both wire them together at the consumer level (see `cmp-sample-shared` for a working example). The biometrics library exposes its own `BiometricStorageAdapter` and registration lifecycle; refer to `mifos-authenticator-biometrics/README.md` for its feature surface.

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ The project is organized into several modules to ensure a clear separation of co
4444

4545
- **`build-logic`**: Contains Gradle convention plugins used to standardize build configurations across all modules (linting, static analysis, multiplatform setup).
4646
- **`mifos-authenticator-passcode`**: A Compose Multiplatform library providing the logic and UI components for passcode authentication.
47-
- **`mifos-authenticator-biometrics`**: A library providing platform-specific implementations for device authentication (Biometrics, Windows Hello, WebAuthn).
47+
- **`mifos-authenticator-biometrics`**: A library providing platform-specific implementations for device authentication (Android/iOS biometrics, Windows Hello).
4848
- **`cmp-sample-shared`**: Contains the shared business logic, navigation, and UI for the sample applications.
4949
- **`cmp-sample-android`**: The Android entry point for the sample application.
5050
- **`cmp-sample-ios`**: The iOS entry point for the sample application.
@@ -56,7 +56,7 @@ The project is organized into several modules to ensure a clear separation of co
5656
- **`androidMain/`**: Implementation using Android `BiometricPrompt`.
5757
- **`iosMain/`**: Implementation using iOS `LocalAuthentication`.
5858
- **`desktopMain/`**: Implementation using JNA for Windows Hello (on Windows) and placeholders for other desktop platforms.
59-
- **`jsMain/` / `wasmJsMain/`**: Implementation using the Web Authentication API (WebAuthn).
59+
- **`jsMain/` / `wasmJsMain/`**: Placeholder — currently returns `NOT_AVAILABLE`. WebAuthn integration is not yet implemented.
6060

6161
### `mifos-authenticator-passcode`
6262
- **`commonMain/`**: Contains the `PasscodeManager`, `PasscodeStorageAdapter`, and the `PasscodeScreen` UI built with Compose Multiplatform.

0 commit comments

Comments
 (0)