Skip to content
This repository was archived by the owner on Apr 29, 2025. It is now read-only.

fix: hide-password icon #30

Open
refactor-droidyy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: hide-password icon #30

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91ca7b9
hide-password icon
refactor-droidyy Mar 1, 2020
d2284c9
Rename ic_visibility_48px to ic_visibility_on_48px
refactor-droidyy Mar 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions mifos-passcode/src/main/java/com/mifos/mobile/passcode/MifosPassCodeActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import androidx.appcompat.app.AlertDialog;
import androidx.appcompat.app.AppCompatActivity;
import androidx.appcompat.widget.AppCompatButton;
import androidx.core.content.ContextCompat;
import androidx.core.widget.NestedScrollView;

public abstract class MifosPassCodeActivity extends AppCompatActivity implements MifosPassCodeView.
Expand Down Expand Up @@ -308,11 +307,9 @@ public void clickedBackSpace(View v) {
public void visibilityChange(View view) {
mifosPassCodeView.revertPassCodeVisibility();
if (!mifosPassCodeView.passcodeVisible()) {
ivVisibility.setColorFilter(ContextCompat.getColor(MifosPassCodeActivity.this,
R.color.light_grey));
ivVisibility.setImageResource(R.drawable.ic_visibility_48px);
Copy link
Copy Markdown

@GOVINDDIXIT GOVINDDIXIT Mar 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@refactor-droidyy Follow similar naming convention, Rename ic_visibility_48px to ic_visibility_on_48px

} else {
ivVisibility.setColorFilter(ContextCompat.getColor(MifosPassCodeActivity.this,
R.color.gray_dark));
ivVisibility.setImageResource(R.drawable.ic_visibility_off_24dp);
}
}

Expand Down
2 changes: 1 addition & 1 deletion mifos-passcode/src/main/res/drawable/ic_visibility_48px.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
android:viewportWidth="48.0"
android:viewportHeight="48.0">
<path
android:fillColor="@color/gray_dark"
android:fillColor="@color/passcode_primary"
android:pathData="M24,9C14,9 5.46,15.22 2,24c3.46,8.78 12,15 22,15s18.54,-6.22 22,-15C42.54,15.22 34.01,9 24,9zM24,34c-5.52,0 -10,-4.48 -10,-10s4.48,-10 10,-10 10,4.48 10,10 -4.48,10 -10,10zM24,18c-3.31,0 -6,2.69 -6,6s2.69,6 6,6 6,-2.69 6,-6 -2.69,-6 -6,-6z" />
</vector>
9 changes: 9 additions & 0 deletions mifos-passcode/src/main/res/drawable/ic_visibility_off_24dp.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="24dp"
android:height="24dp"
android:viewportWidth="24.0"
android:viewportHeight="24.0">
<path
android:fillColor="@color/passcode_primary"
android:pathData="M12,7c2.76,0 5,2.24 5,5 0,0.65 -0.13,1.26 -0.36,1.83l2.92,2.92c1.51,-1.26 2.7,-2.89 3.43,-4.75 -1.73,-4.39 -6,-7.5 -11,-7.5 -1.4,0 -2.74,0.25 -3.98,0.7l2.16,2.16C10.74,7.13 11.35,7 12,7zM2,4.27l2.28,2.28 0.46,0.46C3.08,8.3 1.78,10.02 1,12c1.73,4.39 6,7.5 11,7.5 1.55,0 3.03,-0.3 4.38,-0.84l0.42,0.42L19.73,22 21,20.73 3.27,3 2,4.27zM7.53,9.8l1.55,1.55c-0.05,0.21 -0.08,0.43 -0.08,0.65 0,1.66 1.34,3 3,3 0.22,0 0.44,-0.03 0.65,-0.08l1.55,1.55c-0.67,0.33 -1.41,0.53 -2.2,0.53 -2.76,0 -5,-2.24 -5,-5 0,-0.79 0.2,-1.53 0.53,-2.2zM11.84,9.02l3.15,3.15 0.02,-0.16c0,-1.66 -1.34,-3 -3,-3l-0.17,0.01z"/>
</vector>