feat: c4gt 2025 feature integration#2035
Open
Nagarjuna0033 wants to merge 66 commits into
Open
Conversation
# Conflicts: # cmp-android/prodRelease-badging.txt
… numbers in contact picker
…nd payment details screens
# Conflicts: # cmp-shared/src/commonMain/kotlin/org/mifospay/shared/navigation/MifosNavHost.kt # core/designsystem/src/commonMain/kotlin/org/mifospay/core/designsystem/icon/MifosIcons.kt # feature/mpay-qr-scan/src/commonMain/kotlin/org/mifospay/feature/mpay/qr/scan/di/MpayQrScanModule.kt # feature/mpay-qr-scan/src/commonMain/kotlin/org/mifospay/feature/mpay/qr/scan/navigation/MpayQrScanNavigation.kt # feature/qr/src/commonMain/kotlin/org/mifospay/feature/qr/ScanQrCodeScreen.kt # feature/qr/src/commonMain/kotlin/org/mifospay/feature/qr/ScanQrViewModel.kt # feature/send-money/src/androidMain/kotlin/org/mifospay/feature/send/money/QrScanner.android.kt # feature/send-money/src/commonMain/composeResources/values/strings.xml # feature/send-money/src/commonMain/kotlin/org/mifospay/feature/send/money/SendMoneyScreen.kt # feature/send-money/src/commonMain/kotlin/org/mifospay/feature/send/money/SendMoneyViewModel.kt # feature/send-money/src/commonMain/kotlin/org/mifospay/feature/send/money/navigation/SendNavigation.kt
# Conflicts: # cmp-android/dependencies/prodReleaseRuntimeClasspath.tree.txt # cmp-android/prodRelease-badging.txt # cmp-shared/src/commonMain/kotlin/org/mifospay/shared/navigation/MifosNavHost.kt # core/data/src/commonMain/kotlin/org/mifospay/core/data/util/StandardUpiQrCodeProcessor.kt # core/designsystem/src/commonMain/kotlin/org/mifospay/core/designsystem/icon/MifosIcons.kt # feature/make-transfer/src/commonMain/kotlin/org/mifospay/feature/make/transfer/MakeTransferViewModel.kt # feature/mpay-qr/src/commonMain/kotlin/org/mifospay/feature/mpay/qr/navigation/MpayQrNavigation.kt # feature/send-money/src/commonMain/composeResources/values/strings.xml # feature/send-money/src/commonMain/kotlin/org/mifospay/feature/send/money/PayeeDetailsScreen.kt # feature/send-money/src/commonMain/kotlin/org/mifospay/feature/send/money/PayeeDetailsViewModel.kt # feature/send-money/src/commonMain/kotlin/org/mifospay/feature/send/money/SendMoneyOptionsScreen.kt # feature/send-money/src/commonMain/kotlin/org/mifospay/feature/send/money/SendMoneyViewModel.kt # feature/send-money/src/commonMain/kotlin/org/mifospay/feature/send/money/navigation/SendNavigation.kt # feature/transfer-interbank/src/commonMain/kotlin/org/mifospay/feature/transfer/interbank/di/InterbankTransferModule.kt
# Conflicts: # cmp-android/dependencies/prodReleaseRuntimeClasspath.txt # cmp-android/prodRelease-badging.txt # cmp-shared/build.gradle.kts # cmp-shared/src/commonMain/kotlin/org/mifospay/shared/di/KoinModules.kt # cmp-shared/src/commonMain/kotlin/org/mifospay/shared/navigation/MifosNavHost.kt # core/designsystem/src/commonMain/kotlin/org/mifospay/core/designsystem/icon/MifosIcons.kt # feature/home/src/commonMain/kotlin/org/mifospay/feature/home/HomeScreen.kt # feature/payments/src/commonMain/kotlin/org/mifospay/feature/payments/PaymentsScreen.kt # feature/send-money/src/commonMain/composeResources/values/strings.xml # settings.gradle.kts
# Conflicts: # cmp-shared/src/commonMain/kotlin/org/mifospay/shared/navigation/MifosNavHost.kt # core/data/src/commonMain/kotlin/org/mifospay/core/data/di/RepositoryModule.kt # core/designsystem/src/commonMain/kotlin/org/mifospay/core/designsystem/icon/MifosIcons.kt # core/network/src/commonMain/kotlin/org/mifospay/core/network/FineractApiManager.kt # core/network/src/commonMain/kotlin/org/mifospay/core/network/utils/ApiEndPoints.kt # feature/autopay/README.md
# Conflicts: # cmp-shared/src/commonMain/kotlin/org/mifospay/shared/navigation/MifosNavHost.kt # core/designsystem/src/commonMain/kotlin/org/mifospay/core/designsystem/icon/MifosIcons.kt # core/network/src/commonMain/kotlin/org/mifospay/core/network/KtorfitClient.kt
# Conflicts: # cmp-shared/src/commonMain/kotlin/org/mifospay/shared/navigation/MifosNavHost.kt # core/data/src/commonMain/kotlin/org/mifospay/core/data/di/RepositoryModule.kt
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Uncommented and activated the navigation routes for all `send-money` screens, including payment options, payee details, bank transfers, and payment processing. - Enabled the `Autopay` tab within the payments screen and connected its navigation flow. - Added the `send-money` module to the Koin dependency graph and the main `cmp-shared` build. - Introduced `UpiQrCodeProcessor` for handling custom QR code encoding and decoding. - Migrated from `kotlinx.datetime.Clock` to the stable `kotlin.time.Clock` across the `autopay` and `send-money` features.
Contributor
|
@Nagarjuna0033 Please add the list of PRs that were integrated in this PR, in the PR description. Edit: I have uploaded the screen recording here itself and added the required list of PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated PRs
The following C4GT 2025 feature PRs were originally authored by @biplab1:
This PR integrates the above C4GT feature stack into the new
c4gt-2025branch created from the currentdevelopmentbranch.Integration Changes
send-moneyscreens, including payment options, payee details, bank transfers, and payment processing.Autopaytab within the payments screen and connected its navigation flow.send-moneymodule to the Koin dependency graph and the maincmp-sharedbuild.UpiQrCodeProcessorfor handling custom QR code encoding and decoding.kotlinx.datetime.Clockto the stablekotlin.time.Clockacross theautopayandsend-moneyfeatures.Video reference:
https://mifos.slack.com/archives/C5TTJS4BX/p1778873719160759?thread_ts=1778776671.282059&cid=C5TTJS4BX
upi-autopay-c4gt-2025-features.mp4