PHEE-370: Migrate to Spring Boot 3.4 / JDK 21 / Jakarta EE 10 / Camel 4 (via Mifos Platform BOM)#174
Draft
GiulioRinalduzzi wants to merge 1 commit into
Draft
Conversation
- 17 javax->jakarta imports (servlet, annotation) + 2 fully-qualified javax.servlet refs in PreflightCorsFilter; import order fixed by repo spotless
- build.gradle: versions governed by enforcedPlatform(mifos-platform-bom:1.0.0-SNAPSHOT); SB 2.6.2/2.5.2 mix -> 3.4.4, Camel 3.4 -> 4.4.1, Zeebe 8.1.23 -> 8.4.17, Java 17 -> 21
- ph-ee-connector-common 1.8.1-gazelle -> 2.0.0-SNAPSHOT (Jakarta line)
- HttpClientConfigurerTrustAllCACerts ported HttpClient 4 -> 5 (camel-http 4 passes HC5 builder); same trust-all behaviour
- AuthorizationWorker: Spring 6 getStatusCode() returns HttpStatusCode -> converted to keep HttpStatus signature
- camel-test (JUnit4-only, gone in Camel 4) -> camel-test-junit5
- Removed com.jfrog.artifactory plugin (deploy strategy reworked ecosystem-wide), spotless plugin jar wrongly on app classpath, and legacy org.apache.commons:commons-io:1.3.2 (duplicate of commons-io:commons-io already present)
- AWS SDK v1 kept pinned (used by storage code; v1->v2 is a rewrite, out of scope). retrofit converter-gson aligned 2.4.0 -> 2.9.0 to match the other retrofit modules
- Note: 'test { useJUnitPlatform() }' is commented out on dev (tests silently skipped on baseline) - left as-is, enabling it is a separate concern
- Gradle wrapper 7.3 -> 8.10.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate this connector to Spring Boot 3.4 / JDK 21 / Jakarta EE 10 / Apache Camel 4. All versions come from the Mifos Platform BOM via
enforcedPlatform(...)instead of being pinned by hand.Surgical migration:
javax.*->jakarta.*, versions moved to the BOM, and the minimum changes needed to compile and run. No feature work, no refactoring.Main changes
build.gradle: Spring Boot plugin -> 3.4,io.spring.dependency-management,enforcedPlatform('org.mifos.platform:mifos-platform-bom:1.0.0-SNAPSHOT'); hand-pinned versions removed.ph-ee-connector-common->2.0.0-SNAPSHOTwhere used.javax.*->jakarta.*imports.21-jre.Heads-up for review
ph-ee-connector-common:2.0.0-SNAPSHOTwhere used), not yet published to the official Mifos JFrog. Until then it builds against a local JFrog, so CI here will not pass until those are published upstream.Draft - opening so we can review it together.