Skip to content

fix(loans): fix duplicate routerLinkActive variables and wrong tab la… #3560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harshdhall01 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(loans): fix duplicate routerLinkActive variables and wrong tab la… #3560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/app/loans/loans-view/loans-view.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,10 @@ <h3>{{ 'labels.heading.Account Overview' | translate }}</h3>
productType: loanProductService.productType.value
}"
routerLinkActive
#general="routerLinkActive"
[active]="general.isActive"
#originalSchedule="routerLinkActive"
[active]="originalSchedule.isActive"
>
{{ 'labels.inputs.General' | translate }}
{{ 'labels.inputs.Original Schedule' | translate }}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
</a>
}
<a
Expand All @@ -307,8 +307,8 @@ <h3>{{ 'labels.heading.Account Overview' | translate }}</h3>
productType: loanProductService.productType.value
}"
routerLinkActive
#dashboard="routerLinkActive"
[active]="dashboard.isActive"
#transactions="routerLinkActive"
[active]="transactions.isActive"
>
{{ 'labels.inputs.Transactions' | translate }}
</a>
Expand All @@ -321,10 +321,10 @@ <h3>{{ 'labels.heading.Account Overview' | translate }}</h3>
productType: loanProductService.productType.value
}"
routerLinkActive
#accountdetail="routerLinkActive"
[active]="accountdetail.isActive"
#deferredIncome="routerLinkActive"
[active]="deferredIncome.isActive"
>
{{ 'labels.inputs.Account Details' | translate }}
{{ 'labels.inputs.Deferred income' | translate }}
Copy link
Copy Markdown
Contributor

@IOhacker IOhacker May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Copy Markdown
Member Author

@Harshdhall01 Harshdhall01 May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Deferred Income tab was using #accountdetail as its template reference variable (same as the Account Details tab)
and displaying "Account Details" as its label.
In Angular, duplicate template reference variables cause incorrect active state — both tabs highlight simultaneously.
Fixed variable to #deferredIncome and corrected label to match existing i18n key labels.inputs.Deferred income.

</a>
}
@if (loanProductService.isLoanProduct && loanDetailsData.enableBuyDownFee) {
Expand Down
Loading