Skip to content

WEB-959: Prevent zero amount savings transactions #3600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mahesh-Gite-28 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

WEB-959: Prevent zero amount savings transactions #3600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...-account-actions/savings-account-transactions/savings-account-transactions.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
[isRequired]="true"
[inputFormControl]="savingAccountTransactionForm.controls.transactionAmount"
[inputLabel]="'Transaction Amount'"
[minVal]="0.001"
>
</mifosx-input-amount>

Expand Down
9 changes: 7 additions & 2 deletions ...ng-account-actions/savings-account-transactions/savings-account-transactions.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { SavingsService } from '../../savings.service';
import { SettingsService } from 'app/settings/settings.service';
import { Dates } from 'app/core/utils/dates';
import { Currency } from 'app/shared/models/general.model';
import { amountValueValidator } from 'app/shared/validators/amount-value.validator';
import { InputAmountComponent } from '../../../shared/input-amount/input-amount.component';
import { MatSlideToggle } from '@angular/material/slide-toggle';
import { CdkTextareaAutosize } from '@angular/cdk/text-field';
Expand Down Expand Up @@ -124,8 +125,12 @@ export class SavingsAccountTransactionsComponent implements OnInit {
Validators.required
],
transactionAmount: [
0,
Validators.required
'',
[
Copy link
Copy Markdown
Collaborator

@alberto-art3ch alberto-art3ch May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there is a custom validator for that amountValueValidator

ie:

        principalAmount: [
          '',
          [
            Validators.required,
            amountValueValidator()
          ]
        ],

Plus consider to use in the html field the custom component for Amounts:

      <mifosx-input-amount
        class="flex-48"
        [currency]="currency"
        [isRequired]="true"
        [inputFormControl]="loansAccountTermsForm.controls.principalAmount"
        [inputLabel]="'Principal'"
      >
      </mifosx-input-amount>

Copy link
Copy Markdown
Contributor Author

@Mahesh-Gite-28 Mahesh-Gite-28 May 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alberto-art3ch Updated transactionAmount validation to use amountValueValidator() following the shared validation pattern already used in other amount fields/components.

Kept Validators.min(0.001) to prevent zero-value savings transactions from passing frontend validation.

Also retained the existing mifosx-input-amount component with [minVal]="0.001" for consistent amount validation UI behavior.

Thanks for the review.

Validators.required,
amountValueValidator(),
Validators.min(0.001)
]
],
paymentTypeId: [
'',
Expand Down
Loading