fix(WEB-1038): include template id on update#3724
Conversation
|
Note
|
| Layer / File(s) | Summary |
|---|---|
Create and edit submit payloads src/app/templates/create-edit-template/create-edit-template.component.ts, src/app/templates/create-edit-template/create-edit-template.component.spec.ts |
Edit mode assigns the existing template ID before calling updateTemplate; create mode omits the ID, with tests covering payload fields and mutually exclusive service calls. |
Estimated code review effort: 2 (Simple) | ~10 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title clearly matches the main change: adding the template ID to update requests. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
4062854 to
4d7a27b
Compare
4d7a27b to
5d0ef37
Compare
Summary
Includes the existing template ID in the update request payload when editing a template.
The current template update API requires the template ID in both the request path and request body. The Web App previously supplied it only in the path, causing template updates to fail with an
id.not-nullvalidation error.The template creation flow remains unchanged.
Related issues and discussion
#WEB-1038
Summary by CodeRabbit
Bug Fixes
Tests