Feat datepickers/build nepali datepicker component#3741
Closed
JenishSambahamphe24 wants to merge 15 commits into
Closed
Feat datepickers/build nepali datepicker component#3741JenishSambahamphe24 wants to merge 15 commits into
JenishSambahamphe24 wants to merge 15 commits into
Conversation
fe: landing page UI
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Move inline <style> from index.html to assets/loader.css to fix HTMLHint style-disabled rule. Run prettier --write across the repo to fix 2839 formatting violations that were failing CI.
…I, and login fixes - Replace Institution/Clients/Reports/Admin dropdown menus in toolbar with direct router links; consolidate into Member Management, Reports Overview, and Admin pages - Add CardMenuComponent: generic card-grid landing page driven by route data - Set default redirect to /member-management instead of /home - Compact form field density (density -2) and stepper styles app-wide - Fix login button to be disabled when form is invalid (loginForm.invalid || loading) - Add .form-section wrapper and .resources-section (desktop) to login page so Playwright responsive E2E tests can find the expected CSS classes - Fix E2E docker-compose: set FINERACT_API_URL=http://localhost:4200 so the Angular app routes API calls through Nginx proxy to local Fineract container instead of falling back to the hardcoded external server - Fix Playwright config: ClientsModule is registered at /members not /clients; update routes.ts, client-view.page.ts, close-client.page.ts, and close-client.spec.ts so all URL assertions and navigation use /members/:id
Fe/member management nav
- Members list: blue table header (normal-case headers), white sort arrows, S.No. column, toolbar alignment, card centered to breadcrumb, empty-state fix (@if not [hidden]) - Login page: language selector top-right, Helpful Resources commented out, field backgrounds transparent, footer pinned to bottom - Navbar: language selector restored to toolbar - Typography: set Inter as root font in Material theme config and toolbar tokens; replace Roboto/Tahoma/DM-Sans with Inter in 19 component files so font is consistent across navbar, tables, forms and all pages - Explicit font-family on mat-input placeholder and floating label - Create Member stepper: dynamic step labels, toast on forward nav only, positioned top-right; fix HTMLHint inline-style with .contents-wrapper - Remove text-transform:uppercase app-wide (tables, labels, section heads) - Mobile number validation: exactly 10 digits - Shell: sidenav flex-column so footer stays at page bottom - Translations (en-US): Client → Member for Name, Type, Classification, Status, Transfer, Identifier, and 'No member was found' - E2E: remove .resources-section assertions (section intentionally hidden)
fe: UI polish — members list, login page, form steps, fonts & toasts
|
👋 Hi @JenishSambahamphe24 — thank you for your pull request. This PR is currently blocked because we do not have a Contributor License Agreement (CLA) on file for your GitHub account. To get unblocked:
|
mifos-cla-check
Bot
added
the
cla-required
|
Important Review skippedToo many files! This PR contains 139 files, which is 39 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (13)
📒 Files selected for processing (144)
You can disable this status message by setting the Use the checkbox below for a quick retry:
Note
|
- NepaliDateInputComponent: ControlValueAccessor drop-in for mat-datepicker that displays/accepts Bikram Sambat dates and emits JS Date (AD) to the parent FormControl — no backend changes required - Replaces all four mat-datepickers on the members create form (dateOfBirth, incorpValidityTillDate, submittedOnDate, activationDate) - Supports [minDate]/[maxDate] constraints, custom month/year grid navigation, and viewport-aware panel positioning - AdToBsPipe: converts API number[] dates to BS strings for the Personal Data view - Adds nepali-date-converter to package.json (was installed locally but missing) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
JenishSambahamphe24
force-pushed
the
feat-datepickers/build-nepali-datepicker-component
branch
from
July 21, 2026 03:15
a40e113 to
5aae2d1
Compare
|
👋 Hi @JenishSambahamphe24 — thank you for your pull request. This PR is currently blocked because we do not have a Contributor License Agreement (CLA) on file for your GitHub account. To get unblocked:
|
IOhacker
requested changes
Jul 21, 2026
IOhacker
left a comment
IOhacker
left a comment
Contributor
There was a problem hiding this comment.
Please don't send bulk changes without proper testing. Seems that this a full customization instead of a contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made instead of how they were made. List any dependencies that are required for this change.
Related issues and discussion
#{Issue Number}
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.